From e2dd136c8d75ae742f4363a847ba64471519f4b0 Mon Sep 17 00:00:00 2001 From: Kazuaki Anami Date: Tue, 1 Oct 2024 11:57:03 +0900 Subject: [PATCH 1/2] fix method of update_pteam_service POST to PUT --- api/app/routers/pteams.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/app/routers/pteams.py b/api/app/routers/pteams.py index 20fbae1c..b15dda58 100644 --- a/api/app/routers/pteams.py +++ b/api/app/routers/pteams.py @@ -187,7 +187,7 @@ def get_pteam_services( return sorted(pteam.services, key=lambda x: x.service_name) -@router.post("/{pteam_id}/services/{service_id}", response_model=schemas.PTeamServiceUpdateResponse) +@router.put("/{pteam_id}/services/{service_id}", response_model=schemas.PTeamServiceUpdateResponse) def update_pteam_service( pteam_id: UUID, service_id: UUID, From da91461e073b51ae5b603d78c0fe48fe3a515e38 Mon Sep 17 00:00:00 2001 From: Kazuaki Anami Date: Tue, 1 Oct 2024 11:57:11 +0900 Subject: [PATCH 2/2] fix tests --- api/app/tests/requests/test_pteams.py | 28 +++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/api/app/tests/requests/test_pteams.py b/api/app/tests/requests/test_pteams.py index a6af8330..f47fc547 100644 --- a/api/app/tests/requests/test_pteams.py +++ b/api/app/tests/requests/test_pteams.py @@ -400,7 +400,7 @@ def test_get_pteam_services_verify_if_all_responses_are_filled(service_request, service_id1 = get_service_by_service_name(USER1, pteam1.pteam_id, service_name)["service_id"] - client.post( + client.put( f"/pteams/{pteam1.pteam_id}/services/{service_id1}", headers=headers(USER1), json=service_request, @@ -3528,7 +3528,7 @@ def test_number_of_keywords(self, keywords, expected): } request = {"keywords": keywords} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3577,7 +3577,7 @@ def test_length_of_keyword(self, keyword, expected): } request = {"keywords": [keyword]} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3627,7 +3627,7 @@ def test_length_of_description(self, description, expected): } request = {"description": description} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3665,7 +3665,7 @@ def test_it_should_return_200_when_system_exposure_is_SystemExposureEnum_or_None request = {"system_exposure": system_exposure} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3695,7 +3695,7 @@ def test_it_should_return_422_when_system_exposure_is_not_SystemExposureEnum( request = {"system_exposure": system_exposure} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3730,7 +3730,7 @@ def test_it_should_return_200_when_mission_impact_is_MissionImpactEnum_or_None( request = {"service_mission_impact": service_mission_impact} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3768,7 +3768,7 @@ def test_it_should_return_422_when_mission_impact_is_not_MissionImpactEnum( request = {"service_mission_impact": service_mission_impact} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3803,7 +3803,7 @@ def test_it_should_return_200_when_safety_impact_is_SafetyImpactEnum_or_None( request = {"safety_impact": safety_impact} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3835,7 +3835,7 @@ def test_it_should_return_422_when_safety_impact_is_not_SafetyImpactEnum( request = {"safety_impact": safety_impact} - response = client.post( + response = client.put( f"/pteams/{self.pteam1.pteam_id}/services/{self.service_id1}", headers=_headers, json=request, @@ -3931,7 +3931,7 @@ def test_alert_by_mail_if_vulnerabilities_are_found_when_updating_service( } send_alert_to_pteam = mocker.patch("app.common.send_alert_to_pteam") - response = client.post( + response = client.put( f"/pteams/{self.pteam0.pteam_id}/services/{self.service_id0}", headers=_headers, json=request, @@ -3976,7 +3976,7 @@ def test_not_alert_by_mail_if_unchange_ssvc_priority_when_updating_service( } send_alert_to_pteam = mocker.patch("app.common.send_alert_to_pteam") - response = client.post( + response = client.put( f"/pteams/{self.pteam0.pteam_id}/services/{self.service_id0}", headers=_headers, json=request, @@ -4014,7 +4014,7 @@ def test_not_alert_with_current_ticket_status_is_completed(self, mocker): "safety_impact": models.SafetyImpactEnum.CATASTROPHIC.value, } send_alert_to_pteam = mocker.patch("app.common.send_alert_to_pteam") - response = client.post( + response = client.put( f"/pteams/{self.pteam0.pteam_id}/services/{self.service_id0}", headers=_headers, json=request, @@ -4040,7 +4040,7 @@ def test_not_alert_when_ssvc_deployer_priority_is_lower_than_alert_ssvc_priority } send_alert_to_pteam = mocker.patch("app.common.send_alert_to_pteam") - response = client.post( + response = client.put( f"/pteams/{self.pteam0.pteam_id}/services/{self.service_id0}", headers=_headers, json=request,