Whether encrypt the data at rest, defaults to false Enabling encryption -might impact the performace, see +might impact the performance, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest for the detail Toggling the value will impact encypting/decrypting existing messages. @@ -1627,7 +1627,7 @@ existing messages. (Optional)
Whether enable TLS, defaults to false Enabling TLS might impact the -performace +performance
diff --git a/pkg/apis/numaflow/v1alpha1/generated.proto b/pkg/apis/numaflow/v1alpha1/generated.proto index 89cf4f63d7..56bae2bbc6 100644 --- a/pkg/apis/numaflow/v1alpha1/generated.proto +++ b/pkg/apis/numaflow/v1alpha1/generated.proto @@ -447,13 +447,13 @@ message JetStreamBufferService { optional string bufferConfig = 18; // Whether encrypt the data at rest, defaults to false - // Enabling encryption might impact the performace, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest for the detail + // Enabling encryption might impact the performance, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest for the detail // Toggling the value will impact encypting/decrypting existing messages. // +optional optional bool encryption = 19; // Whether enable TLS, defaults to false - // Enabling TLS might impact the performace + // Enabling TLS might impact the performance // +optional optional bool tls = 20; } diff --git a/pkg/apis/numaflow/v1alpha1/jetstream_buffer_service.go b/pkg/apis/numaflow/v1alpha1/jetstream_buffer_service.go index 19b8b19ad3..4be0735bc2 100644 --- a/pkg/apis/numaflow/v1alpha1/jetstream_buffer_service.go +++ b/pkg/apis/numaflow/v1alpha1/jetstream_buffer_service.go @@ -93,12 +93,12 @@ type JetStreamBufferService struct { // +optional BufferConfig *string `json:"bufferConfig,omitempty" protobuf:"bytes,18,opt,name=bufferConfig"` // Whether encrypt the data at rest, defaults to false - // Enabling encryption might impact the performace, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest for the detail + // Enabling encryption might impact the performance, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest for the detail // Toggling the value will impact encypting/decrypting existing messages. // +optional Encryption bool `json:"encryption,omitempty" protobuf:"bytes,19,opt,name=encryption"` // Whether enable TLS, defaults to false - // Enabling TLS might impact the performace + // Enabling TLS might impact the performance // +optional TLS bool `json:"tls,omitempty" protobuf:"bytes,20,opt,name=tls"` } diff --git a/pkg/isb/redis/read.go b/pkg/isb/redis/read.go index 05fec63071..8c09481e24 100644 --- a/pkg/isb/redis/read.go +++ b/pkg/isb/redis/read.go @@ -226,7 +226,7 @@ func (br *BufferRead) Read(_ context.Context, count int64) ([]*isb.ReadMessage, return messages, fmt.Errorf("XReadGroup failed, %w", err) } - // NOTE: If all messages have been delivered and acknowleged, the XREADGROUP 0-0 call returns an empty + // NOTE: If all messages have been delivered and acknowledged, the XREADGROUP 0-0 call returns an empty // list of messages in the stream. At this point we want to read everything from last delivered which would be > if len(xstreams) == 1 && len(xstreams[0].Messages) == 0 { br.log.Infow("We have delivered and acknowledged all PENDING msgs, setting checkBacklog to false") diff --git a/pkg/isb/redis/write.go b/pkg/isb/redis/write.go index 6783d2c328..c8c7353996 100644 --- a/pkg/isb/redis/write.go +++ b/pkg/isb/redis/write.go @@ -116,7 +116,7 @@ func (bw *BufferWrite) refreshWriteInfo(ctx context.Context) { } } -// trim is used to explicity call TRIM on buffer being full +// trim is used to explicitly call TRIM on buffer being full func (bw *BufferWrite) trim(_ context.Context) { ctx := clients.RedisContext bw.log.Infow("Explicit trim on MINID", zap.String("MINID", bw.minId.Load())) diff --git a/pkg/sources/kafka/metrics.go b/pkg/sources/kafka/metrics.go index 8594f26b97..a78e0fa25a 100644 --- a/pkg/sources/kafka/metrics.go +++ b/pkg/sources/kafka/metrics.go @@ -12,11 +12,11 @@ var kafkaSourceReadCount = promauto.NewCounterVec(prometheus.CounterOpts{ Help: "Total number of messages Read", }, []string{"vertex", "pipeline"}) -// kafkaSourceAckCount is used to indicate the number of messages Acknowleged +// kafkaSourceAckCount is used to indicate the number of messages Acknowledged var kafkaSourceAckCount = promauto.NewCounterVec(prometheus.CounterOpts{ Subsystem: "kafka_source", Name: "ack_total", - Help: "Total number of messages Acknowleged", + Help: "Total number of messages Acknowledged", }, []string{"vertex", "pipeline"}) // kafkaSourceOffsetAckErrors is used to indicate the number of errors while reading from kafka source with offsets