Code review and merge GoPro feature

[sync-by-unito]

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

[sync-by-unito]

➤ Tammy Yang commented:

Scott Yan please help provide materials Yi-Min Lin need to finish this task.

[sync-by-unito]

➤ Yi-Min Lin commented:

Scott Yan 需要知道關於這個 task 的細節，請問是指 merge 這個 PR 嗎？
#1133 ( #1133 )

[sync-by-unito]

➤ Scott Yan commented:

Yi-Min Lin 我的理解是 gopro 整個功能要加入 capture app 中
上面這一個是新增重整按鍵我不確定有沒有包含 app 與 gopro 連線的部分

[sync-by-unito]

➤ Yi-Min Lin commented:

後來 lint 以及 test 的問題就解決了
lint 大部分有修掉，剩下兩個 error 比較不知道怎麼處理，數量也不多，就先使用 eslint ignore comment 暫時忽略：

1. // eslint-disable-next-line no-async-promise-executor
2. // eslint-disable-next-line @typescript-eslint/no-magic-numbers

[sync-by-unito]

➤ James Chien commented:

Ray Hung

GoPro feature PR: #1205 ( #1205 )

The goal of the task is to merge the go-pro beta 1.0 branch into develop. Please co-work with Scott Yan for the expectation of the merged feature, might need to make some small adjustments (for example we're hiding the GoPro feature UI now, may need to reveal it)

Currently waiting for Sultanmyrza to address issues in this PR. When it is done, code will be merge to feature/experiments/go-pro/beta/1.0 ( https://github.com/numbersprotocol/capture-lite/tree/feature/experiments/go-pro/beta/1.0 ). Since I don't have a GoPro device for testing I'm doing code review without actually testing the functionalities. You might need to work with Scott (and see if you can have a GoPro for testing) to make sure the feature works as intended.

[sync-by-unito]

➤ James Chien commented:

From scott: #1 就依照點七下顯示 -> 可以連結上 gopro -> 單張上傳註冊成功為基準沒有問題 ( 如果需要先協助測試可以先給 apk )

There is no need to merge PR#1205, the current develop branch already includes the required feature

[sync-by-unito]

➤ Ray Hung commented:

James ChienScott Yan So is there anything additional I need to do for this task? Or I should just wait till Thursday and do the release?

[sync-by-unito]

➤ James Chien commented:

Scott will help testing the apk (0.47.0, GoPro feature incuded). If there's no additional issues discovered during the test, no action is needed on this task.

[sync-by-unito]

➤ Ray Hung commented:

0.48.1 QA testing passed ( https://dt42-numbers.slack.com/archives/CSE9MG0FR/p1644839832064929 ). Marking as complete.