Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide at least two resolution options for users #1808

Closed
sync-by-unito bot opened this issue Jul 12, 2022 · 15 comments
Closed

Provide at least two resolution options for users #1808

sync-by-unito bot opened this issue Jul 12, 2022 · 15 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 12, 2022

User story:

As a user, I want to see at lease two resolution options in the camera so that I can choose from either creating high-res but big images or mid-res but smaller images.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 29, 2022

➤ Sam commented:

Kenny Hung, (cc: Tammy Yang).
Since there was no UI for changing quality I have this simple UI proposal [demo]. Let me know if there any feedback.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 29, 2022

➤ Kenny Hung commented:

SamTammy Yang I think maybe the icon or UI need Noir's suggestion and make sure it's fit the design guideline.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 29, 2022

➤ Tammy Yang commented:

Kenny Hung for Camera, I think it's ok that we propose the UI ourselves

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 29, 2022

➤ Tammy Yang commented:

Sam Only one question to this proposal, I am confused (as a user) what doest it mean by "Hi" and "Low"

Should we show the exact solution option? Maybe a settings menu will be better?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 29, 2022

➤ Sam commented:

Tammy Yang, agree. It's bit hard to understand. I can do separate screen with settings. Also, I can ask the noir team. Should I ask them?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 29, 2022

➤ Tammy Yang commented:

Sam you can ask Noir team, but we don't necessary need to follow them if the suggestion is challenging from the tech point of view. I think you can send them your video so that they at least have some sense of "what's the easiest way to achieve this"

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 29, 2022

➤ Sam commented:

Tammy Yang, I saw the conversation ( https://dt42-numbers.slack.com/archives/C03NMG0KQ67/p1664440378442879 ). Are we implementing this feat or need to wait until clarification?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 30, 2022

➤ Tammy Yang commented:

Samhttps://dt42-numbers.slack.com/archives/C0323488MEJ/p1664513850619789 ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1664513850619789 )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 3, 2022

➤ Sam commented:

Tammy Yang, Today I read the slack message ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1664513850619789 ) again and realized that I implemented set quality the wrong way. I was focusing on degrading the quality of photo/video as shown in early previews for iOS ( https://app.claap.io/numbers-protocol/devs-qa-early-preview-of-camera-quality-low-hq-i-os-only-c-O35CsUM4Uy-hPBjYsgaPRRY ) and Android ( https://app.claap.io/numbers-protocol/android-set-quality-feat-early-preview-c-O35CsUM4Uy-XqUiuopCXBDE ).

Max means using the highest possible resolution of the camera.
What do you expect from Social? Because I found this post ( https://www.picmonkey.com/blog/size-matters-instagram-photo-sizes-made-easy ) about IG sizes and it has multiple cases:

  1. Instagram ad (single image or carousel): 1080 x 1080 px
  2. Instagram post: 1080 x 1080 px (1:1 ratio)
  3. Instagram profile photo: 360 x 360 px
  4. Instagram landscape photo: 1080 x 608 px (1.91:1 ratio)
  5. Instagram portrait: 1080 x 1350 px (4:5 ratio)
  6. Instagram story: 1080 x 1920 px (9:16 ratio)
  7. IGTV cover photo: 420 x 654 (1:1.55 ratio)
  8. IGTV and Reel video: 1080 x 1920 px (9:16 aspect ratio)

My question is should I use size #2 for both photo/video from front/back cameras?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 3, 2022

➤ Tammy Yang commented:

Sam let's do 6 (image), 8 (video)?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 3, 2022

➤ Tammy Yang commented:

Basically just 1080x1920

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 3, 2022

➤ Sam commented:

Tammy Yang
Max settings:
Landscape photo/video => Max possible Width - Height
Portrait photo/video => Max Possible Width - Height

Social Settings
Landscape photo/video => 1920 x 1080 (16:9)
Portrait photo/video => 1080 x 1920 (9:16)

Is it correct?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 3, 2022

➤ Tammy Yang commented:

Sam sounds good to me.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 4, 2022

➤ Sam commented:

Tammy Yang, I would usually ask Sofia but you can provide a better translation for this particular case since you know the context. [screenshot ( https://i.imgur.com/S38zOpy.png )]
Max =最大
Social = 社會的

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 4, 2022

➤ Sam commented:

Bofu Chen here is the PR ( #2154 ).
Here is the claap ( https://app.claap.io/numbers-protocol/devs-only-max-social-size-ios-android-c-O35CsUM4Uy-cP_tMyzaSNow ) for the PR demo.

@sync-by-unito sync-by-unito bot closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants