Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[need to confirm]share button on prod page should display what? #1952

Open
sync-by-unito bot opened this issue Aug 19, 2022 · 9 comments
Open

[need to confirm]share button on prod page should display what? #1952

sync-by-unito bot opened this issue Aug 19, 2022 · 9 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 19, 2022

In the product page: when user press the share button, it will display this currently.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung
┆Link To Task: https://app.asana.com/0/1201016280880500/1202820070996824

@sync-by-unito sync-by-unito bot changed the title [need to confirm] [need to confirm]prod page share button should display what? Aug 19, 2022
@sync-by-unito sync-by-unito bot changed the title [need to confirm]prod page share button should display what? [need to confirm]share button on prod page should display what? Nov 7, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Kenny Hung commented:

Tammy YangEthan WuSam (cc Scott Yan)
Just confirm two parts.

  1. When user press the share button, it will display above, I think if we could display the normal share list like this ( https://app.asana.com/app/asana/-/get_asset?asset_id=1202820070996831 ), maybe it could be convenient for users.
  2. Does the copy link use copy the iframe URL or CC prod link?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Tammy Yang commented:

Kenny Hung

For 1: Is this for Asset sharing? Why do we want to show invitation code?
For 2: Good question. Ideally, I believe we want users to share the new design for the product (i.e. iframe URL), however, this involves the question of "whether or not and when do we want to add the desktop support for the new iframe". Therefore, we can accept it link to CC prod for now, but need to have a task to track the update.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Kenny Hung commented:

Tammy Yang
#1 I mean use the mobile phone share feature not invitation code, its just an example, it could be like this ( https://asana-user-private-us-east-1.s3.us-east-1.amazonaws.com/assets/1200886955782960/1202820070996836/582ed2cb0671e2c9e9387f469aa551c9?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=ASIAV34L4ZY4CISFUJ6O%2F20220819%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20220819T102953Z&X-Amz-Expires=120&X-Amz-Security-Token=IQoJb3JpZ2luX2VjELL%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJGMEQCIGZ9dY%2F176RXGCUUbT3uKZ%2B78M78H5Tko3351Ci5Azx%2BAiBr1pwU1YMrr%2F6GtokagH6t%2BBCLtPHNVvPbwMGgi268pSrTBAgrEAAaDDQwMzQ4MzQ0Njg0MCIMOcxRhepJqVkUp21jKrAEIG2onhgSIaF96bgkp6Y9OyxRe9Rgfqy3gP4DZGNwzEDfOTcd1WEbAPra7QDebqVK8ViVZgvDuSwzd7wSw2z1TuflVVbOhmfktASX4b1FVMn82r5RQiZ0hPNoFu8pAKSbX2V5yLgS6Piw5y59IFvMU8yvhhVsUDQce1%2FSACYSHojHY9Hcoi2gQDs16DMtwAINy5mLhrRfmXD3mTaFZDtrn2qLVFcDtruvrmXaVBSvJo%2B%2F5bTMGCNKzpHlzLjAyrxaQtKB9cj2kd7DrmZuga5%2B7uGbGhfSBgObfS8Q%2BmKlNevlP1PvJb4H%2BogOljzEYfP1Qh%2BbFaC%2BLYUcNaH%2FafSDnylUsBMFP8GGvZ0XzkqAANlZlL%2BJIO5ZbwwvBHlj1BS1tQ%2BUbPvwstSmBP%2BCDfjUYj2F8dGTZaOwduJR1yLYmymcJnBLQNi5zdxPeaLctKvUw6KTS82FJELpeIuHR0yjt%2F%2B0WrpEFSFGim6VSsCzfoxRo8%2FysAqE4SA1DezXd9EyJaudFfpfJEtj1CBsHUZBt3AE8ds73MxqykNJB8yctT4JiAXDYSUB331dMltw77IX3NyPCxJ%2BVUvfQU3acRcvdsA%2BJvppO9l75g327usrJRDn1wDKw%2FBmETyjlmnDzWugxSDDFQVaHh6%2FoeHD7x30ll5aHW6Ga3aGl4jKvXwdbmIMi1eHcR6SDXKbbC%2Bs8corST1WUv72KRUHcuKtqQtXIt0wtEnyxParEux5LzI5js8w6r39lwY6qgEpxNm8Ks4bW2%2BPbW9KOavbo7SODx2qyyB0JpA4hJ9mxo1EjeuevKn01cJLLwEBAJYFEGT06VtVU%2F6JvZ6Uj4264DOsmye3a%2BsMSNphBYDCy7eGQ1W7N0mRiEHEwXU2qeWvk6IdU2mbyrZS19sEzBzNjcuaUXvVX7ATNjITA6ZfwvJcGaXY4uoc1rFdHs9FjzZTYT7g4FoetSoe3496hGMl%2F6%2FkAppFxxUFfg%3D%3D&X-Amz-Signature=b8fa51a0e06a2917fe83e2d55a10b3ea171931d60a71cec880c513a5ae2d34c8&X-Amz-SignedHeaders=host&x-id=GetObject#_=_ ).
I think the pros is that it could let user have more flexibility of sharing not only share by default apps.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Kenny Hung commented:

Tammy Yang
#2 I create a new task ✓ [FR] share link of prod page use CC prod link temporarily ( https://app.asana.com/0/1201016280880500/1202820070996843/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Ethan Wu commented:

Kenny Hung bc this is bubble its not possible to access mobile share functions like the one that you have pictured above. It needs to be done on the app side.

If we want bubble to do this than we need to implement the current project as a native bubble app. We will need to use the bdk plugin https://thebdk.com/ ( https://thebdk.com/ )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Ethan Wu commented:

The copy link uses iframe link

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Tammy Yang commented:

Although, there are some issues, but we will not consider changing the App framework yet. Let's find the solution based on the assumption that we will live with Ionic framework.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

➤ Tammy Yang commented:

SamEthan Wu please help try this, leave the top bar implemented with Ionic and let's see how it goes.

I.e. when back button is pressed, it will go to the last page where Ionic App recognized, not the actual "last page" in the iframe.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants