Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] share link of prod page use CC prod link temporarily #1953

Closed
sync-by-unito bot opened this issue Aug 19, 2022 · 14 comments
Closed

[FR] share link of prod page use CC prod link temporarily #1953

sync-by-unito bot opened this issue Aug 19, 2022 · 14 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 19, 2022

This task is about [need to confirm]share button on prod page should display what?
User flow:

  1. press the prod of explore tab
  2. press the share button
  3. copy the link will be replaced for CC prod link

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot changed the title [FR]share link of prod page use CC prod link temporarily [FR] share link of prod page use CC prod link temporarily Sep 6, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Sam commented:

Kenny Hung, are we talking about the Share Asset Profile button [screenshot ( https://i.imgur.com/KtmP15c.png )]?😅

I didn't understand this part
👉 3. copy the link will be replaced for CC prod link

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 12, 2022

➤ Kenny Hung commented:

Sam No, it's on explore tab.
Like this img.
Repro step

  1. open app
  2. choose a prod from explore tab
  3. press share icon upper right corner.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 13, 2022

➤ Sam commented:

Ethan Wu (cc: Kenny Hung)
This share button is inside the iframe so it should be done from the bubble side😅😇.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 13, 2022

➤ Ethan Wu commented:

Kenny Hung what should the share link be?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 13, 2022

➤ Tammy Yang commented:

Ethan Wu asset profile of search engine

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 13, 2022

➤ Ethan Wu commented:

this is done.

change was made to v220915 branch => new branch created from qa-release

@sync-by-unito sync-by-unito bot closed this as completed Sep 13, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Kenny Hung commented:

Ethan Wu (cc Tammy YangSamScott Yan)
#1 share link of prod page doesn’t change entire feature.
Reproduce step

  1. open app & choose a product on explore tab
  2. press the share button
  3. press facebook/pintrest/twitter
  4. could still see the iframe url

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Ethan Wu commented:

ok i will make the change.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Ethan Wu commented:

Kenny Hung try again

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Kenny Hung commented:

Ethan Wu it display this.
Reproduce step

  1. open app & choose a product on explore tab
  2. press the share button
  3. press facebook/pintrest/twitter

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Kenny Hung commented:

Ethan Wu If it needs a lot of time to fixed, I think this part could be convert to back now, and adjust this afterward.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Ethan Wu commented:

Kenny Hung this might be an issue with the plugin itself. let me see one sec

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Ethan Wu commented:

Kenny Hung it should work now

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 16, 2022

➤ Ethan Wu commented:

Kenny Hung i fixed it. no need to convert it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants