MoonPay integration

[sync-by-unito]

• Dashboard: https://dashboard.moonpay.com/
• Account: [email protected]
  ​
  num-custody-payment: 0x7dFCedd2a008d3c0cb09887D5f03e4f01B8538e6
  num-custody-recipient: 0x3912F7d6787AC42C7c7E016dECBA0A6Eb68Eb05b

┆Issue is synchronized with this Asana task by Unito
┆Created By: Vera Wu

[sync-by-unito]

➤ Vera Wu commented:

https://dashboard.moonpay.com/ ( https://dashboard.moonpay.com/ )

簽好約了，可以開始在系統內操作。
有需要請他們技術人員開群組在跟我說

[sync-by-unito]

➤ Vera Wu commented:

我有在鋪路邀請他們來 rebrand
我目前的窗口在英國感覺可以 （算是在鋪路看之後可不可以文贊助的事情）

我這邊另外想了解的事
如果我可以在背景作業轉緩幣
直接讓使用者看起來他是直接買 num

那我是不是也可以 在背景作業 讓他直接買產品 （我在背景先完成買 whatever crypto 再支付給我們 的作業）

只是可能他們還是要註冊帳號（moonpay)
好處是 我們沒有什麼卡片被盜刷這種要處理的事

[sync-by-unito]

➤ Tammy Yang commented:

買 NFT 這種事直接付費接 MoonPay 主推的 API Hypermint 他們應該會更喜歡你 😆

[sync-by-unito]

➤ Vera Wu commented:

Tammy Yang moo pay is asking for the update
May we have a rough schedule to integrate this ?

[sync-by-unito]

➤ Tammy Yang commented:

Tell them RD team is working on it. Will share more later.

[sync-by-unito]

➤ Vera Wu commented:

update per Dev schedule ( https://docs.google.com/spreadsheets/d/1IEflC0_h5MEuBtwtPmtgw-7kZYDklTX_RabwVINm-UY/edit#gid=1060411730 )

[sync-by-unito]

➤ Vera Wu commented:

MoonPay 上線要不要做 partnership announcement ?

[sync-by-unito]

➤ Tammy Yang commented:

可以，也讓他們在 mainnet 宣傳期間幫我們抬轎吧

[sync-by-unito]

➤ Vera Wu commented:

They also agr w/ partnership announcement
Will prepare the draft

[sync-by-unito]

➤ Tammy Yang commented:

Vera Wu 請問登入帳號密碼? (麻煩 DM or Signal 給我)

[sync-by-unito]

➤ Vera Wu commented:

Tammy Yang 我之前就邀請你為 administer，你應該要用你的 email 登入，我重新邀請你一次了，你應該會收到 email

[sync-by-unito]

➤ Tammy Yang commented:

Bofu Chen

Suggested flow: https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534151525217&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534151525217&cot=14 )
Testing transaction: https://goerli.etherscan.io/tx/0x6dea0e4964cc92ec1fd3a67da75498f8d1d18352c799cd0fe9ce7bd7a17b2542 ( https://goerli.etherscan.io/tx/0x6dea0e4964cc92ec1fd3a67da75498f8d1d18352c799cd0fe9ce7bd7a17b2542 )

目前遇到的問題

1. Webhook 沒有自動跳轉回指定的頁面
2. Signature verification 尚未實作
3. 打錢給用戶 asset 錢包這段尚未實作

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu moonpay-demo has been transfer to you

Miro: https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534151525217&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534151525217&cot=14 )
Claap: https://app.claap.io/numbers-protocol/dev-moonpay-integration-c-O35CsUM4Uy-0QRxbLyfe9V0 ( https://app.claap.io/numbers-protocol/dev-moonpay-integration-c-O35CsUM4Uy-0QRxbLyfe9V0 )

Please make sure the release focuses very much on changes of the checkout page. Let me and QA know if you need more time to integrate Moonpay into the current iframe. It is ok to delay it a bit.

[sync-by-unito]

➤ Tammy Yang commented:

Testing URL for demo App

https://moonpay-demo.bubbleapps.io/version-test?amount=100&token=heyhey&wallet=0x4718e08377292B4b243a6E891D14e10967E1652F ( https://moonpay-demo.bubbleapps.io/version-test?amount=100&token=heyhey&wallet=0x4718e08377292B4b243a6E891D14e10967E1652F )

[sync-by-unito]

➤ Tammy Yang commented:

For the redirect page, Moonpay widget requires you to send the encoded URL. You may need this site https://www.w3schools.com/tags/ref_urlencode.ASP ( https://www.w3schools.com/tags/ref_urlencode.ASP )

[sync-by-unito]

➤ Tammy Yang commented:

Some tricks for efficient test:

1. Always use TW address and nationality (it can be fake)
2. After buying USDC for three times, Moonpay widget will stop you from buying again but ask you to complete KYC. Go to "Settings" and delete the account, then you can keep working on it without going through KYC

Testing credit card:

Card number: 2222755234426838
Expired date: 01/2024
Code: 123

[sync-by-unito]

➤ Bofu Chen commented:

Tammy YangEthan Wu Custodial ERC20 Payer (Bubble plugin) for the MoonPay integration is ready.

Here is the plugin architecture ( https://miro.com/app/board/o9J_knFcMnw=/?moveToWidget=3458764534379724624&cot=14 ).

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang is it possible to share with me the service wallet address?

[sync-by-unito]

➤ Bofu Chen commented:

Ethan Wu I'm preparing the wallet and will share the wallet info here soon.

I guess that you will need not only the wallet address but also the private key for setting the plugin?

[sync-by-unito]

➤ Bofu Chen commented:

Ethan Wu numbers-custody-payment wallet: 0x7dFCedd2a008d3c0cb09887D5f03e4f01B8538e6

1. Joanne had deposited 100 BEP20 mainnet NUM to the wallet.
2. I had deposited 100 BEP20 testnet NUM to the wallet.

You can share the Bubble App with the Custody Payment plugin with me. I can help set the private key in the plugin.

[sync-by-unito]

➤ Ethan Wu commented:

Bofu Chen is the plugin for the custodial erc20 payer created already?

[sync-by-unito]

➤ Bofu Chen commented:

Ethan Wu Yes you can get the info in the comment above ( https://app.asana.com/0/0/1202479143365858/1203044509038812/f ). Let me know if anything is missing and I will update it

[sync-by-unito]

➤ Ethan Wu commented:

Bofu Chen ok. the bubble app is: capture-app-iframe

[sync-by-unito]

➤ Ethan Wu commented:

let me know if you need any more information

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu maybe also provide Bofu Chen the demo app?

[sync-by-unito]

➤ Ethan Wu commented:

Bofu Chen demo app name: Moonpay-demo

[sync-by-unito]

➤ Bofu Chen commented:

Ethan Wu Both captureappiframe and moonpay-demo can use the custodial payer plugin now.

I've set the plugin configs to captureappiframe. You can set moonpay-demo by referencing captureappiframe because I can not find moonpay-demo and set the configs for you.

[sync-by-unito]

➤ Ethan Wu commented:

status:

• preliminary testing in captureiframe => added iframe to element (issue with MoonPay widget)
• inquiry sent on Telegram

will work on other features (follow) while waiting for feedback & adjust the UI of checkout page according to MIRO

[sync-by-unito]

➤ Tammy Yang commented:

Moonpay feedback

@ethanwu155

• There’s two ampersands in their URL. If you look right before quoteCurrencyAmount there should only be one “&”
• After isolating the above issues your redirectUrl appears to work fine. Redirected to the attached screenshot
• Please also take note Binance doesn't support USDC anymore (https://www.bsc.news/post/what-you-need-to-know-about-binance-s-new-stablecoin-policy ( https://www.bsc.news/post/what-you-need-to-know-about-binance-s-new-stablecoin-policy ))

The revised below URL works now. (removed double &&).

https://buy-sandbox.moonpay.com/?apiKey=pk_test_tQV95Q6ZbfbaMPPMbBvJ5d4OuyJUdJ&currencyCode=usdc&walletAddress=0x4718e08377292B4b243a6E891D14e10967E1652F&quoteCurrencyAmount=100&baseCurrencyCode=usd&redirectURL=https%3A%2F%2Fbofu-playground.bubbleapps.io/version-test/moonpay-demo%2F%3Ftoken%3Dheyhey ( https://buy-sandbox.moonpay.com/?apiKey=pk_test_tQV95Q6ZbfbaMPPMbBvJ5d4OuyJUdJ&currencyCode=usdc&walletAddress=0x4718e08377292B4b243a6E891D14e10967E1652F&quoteCurrencyAmount=100&baseCurrencyCode=usd&redirectURL=https%3A%2F%2Fbofu-playground.bubbleapps.io/version-test/moonpay-demo%2F%3Ftoken%3Dheyhey )

Note: In our production environment, we require the signature parameter (step 3) at the end of the widget URL whenever the walletAddress is used. We validate this and if it’s not passed properly the widget will fail to load.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu

Link Element that opens new tab
Need to check if the URL parameters are correct

Configurations for backend webhook
It should be done, yes, need more tests.

Backend webhook Logic => check if transaction complete, check service wallet, check usdc charged, transfer
Need to be done

Pulling for moonpay_status = complete and do the rest of the payment flow
Need to be done

The countdown of the checkout page may cause some problems, please make some more tests to make sure we understand all conditions (as many as possible).

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang
i think there are some other issues tied with order timeout.

users will need to complete moonpay transaction before the 5 minute time frame otherwise the order will expire and need to be reinitialized.

this means at any point during the checkout process (ie: waiting for moonpay transaction to finish) if its not completed within the 5 minute window the order will expire.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu let's first continue the implementation and try if 50% users can finish the Moonpay transaction on time.

Or, when it is expired, we can set moonpay_status of the Order to "expired". When the transaction completes, return data to webhook, and the status is expired => create a new Order for user?

[sync-by-unito]

➤ Ethan Wu commented:

my current thoughts are the following:

1. we need to implement the entire moonpay flow post moonpay payment widget opening as a backend workflow. this is because there is a high likelihood that we will be navigated away from the checkout page. if we want the process to run in the background we will need to leverage backend workflow
2. my original plan is the following => if user reaches the point where they need to confirm order i will check to see if the order returns an error (signifying the order has expired) if so i will create another order using the same cid and confirm that order. at the same time update the order db entry with the new order_id.

[sync-by-unito]

➤ Ethan Wu commented:

need to include the following into the db diagram in order to run the backend workflow:

access_token & refresh_token => for storage backend - confirm order

user wallet address => for transfer action

[sync-by-unito]

➤ Tammy Yang commented:

Including token in the db may be a problem. However, since it's JWT tokens only, maybe it's fine. However, I would still suggest to open a task to recisit and update this design two months later.

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang MoonPay integrated. I tested and confirm the flow works.

There is an issue where the webhook is called multiple times. This causes NUM transfer and order confirmation to fire multiple times. After discussing with bofu we think it might be a moonpay issue.

I have sent a detailed inquiry on telegram.

While I wait for response do I release iframe to qa without MoonPay?

[sync-by-unito]

➤ Ethan Wu commented:

Thread with details https://dt42-numbers.slack.com/archives/C0323488MEJ/p1664869261433289?thread_ts=1664869261.433289&cid=C0323488MEJ ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1664869261433289?thread_ts=1664869261.433289&cid=C0323488MEJ )

[sync-by-unito]

➤ Ethan Wu commented:

i added some steps in the workflow to prevent transfer and order confirmation from triggering if it has already been initiated. moonpay should work as expected even with webhook being called multiple times.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung

when testing:

pls note that NUM transfer (because it is in qa-release branch) happens on the testnet while order confirmation uses production storage backend.

when you are testing message me to find out more details on how to test.

[sync-by-unito]

➤ Tammy Yang commented:

Bofu Chen

Plugin server side action console error
Error: replacement fee too low [ See: https://links.ethers.org/v5-errors-REPLACEMENT_UNDERPRICED ( https://links.ethers.org/v5-errors-REPLACEMENT_UNDERPRICED ) ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":55,\"error\":{\"code\":-32000,\"message\":\"replacement transaction underpriced\"}}\n","error":{"code":-32000},"requestBody":"{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0xf8aa178502540be40082cac0942c1ea36d62382d24ad7f4ea49e322e00616a6bb380b844a9059cbb0000000000000000000000003f5d360eb5c48fb60a6e3391736bb37f21f428c400000000000000000000000000000000000000000000003680590c747404740081e6a0313498ebc10e69e8aff28eda40e4a9ffb7f017d33d0c3bf3cb8e988734b6d394a033fbbdcd7d611b20723b5e167ac55457ce85b834a1c39bc61a53f11585b7b218\"],\"id\":55,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"https://data-seed-prebsc-1-s1.binance.org:8545/"} ( https://data-seed-prebsc-1-s1.binance.org:8545/&quot;} ), method="sendTransaction", transaction="0xf8aa178502540be40082cac0942c1ea36d62382d24ad7f4ea49e322e00616a6bb380b844a9059cbb0000000000000000000000003f5d360eb5c48fb60a6e3391736bb37f21f428c400000000000000000000000000000000000000000000003680590c747404740081e6a0313498ebc10e69e8aff28eda40e4a9ffb7f017d33d0c3bf3cb8e988734b6d394a033fbbdcd7d611b20723b5e167ac55457ce85b834a1c39bc61a53f11585b7b218", code=REPLACEMENT_UNDERPRICED, version=providers/5.7.1) at Logger.makeError (/var/task/node_modules/@ethersproject/logger/lib/index.js:238:21) at Logger.throwError (/var/task/node_modules/@ethersproject/logger/lib/index.js:247:20) at checkError (/var/task/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:160:16) at JsonRpcProvider.<anonymous> (/var/task/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:751:47) at step (/var/task/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:48:23) at Object.throw (/var/task/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:29:53) at rejected (/var/task/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:21:65) at processTicksAndRejections (inte

[sync-by-unito]

➤ Tammy Yang commented:

Re-open the issue because the transaction cannot be completed. I have opened an issue (see Capture is not transferred properly after Moonpay payment is done ( https://app.asana.com/0/0/1203127623144856 )), however, I do believe it was due to the implementation of Moopay in the iframe side.

Some issues observed

1. QA (and all other dev version) uses BSC testnet instead of BSC mainnet => even though the transfer completes, order in the backend cannot completes because there are still no mainnet NUM in the user's asset wallet
2. Even if we have fixed Bump @capacitor/cli from 2.2.1 to 2.3.0 #1, there is no NUM in the transfer wallet 😅
3. Even if we have fixed Bump @capacitor/cli from 2.2.1 to 2.3.0 #1 and add NUM to the transfer wallet (mainnet), there is still a time difference between a. NUM sent to users' asset wallet b. backend order confirmation. In other words, when backend is requested to confirm the order, the transaction has not yet completed. This results in insufficient fund exception, but the NUM actually appear in user's wallet some time leter.

Will work on this tomorrow.

[sync-by-unito]

➤ Tammy Yang commented:

Besides and check_order_status returns 401 exception ( https://app.asana.com/0/0/1203128894956970 ) still show exceptions, I have tested the end-to-end process and make sure checkout with Moonpay can be done successfully.

[sync-by-unito]

➤ Kenny Hung commented:

After complete moonpay checkout process. User come back to App and redirect to explore page. But nothing happened, the prod is still in the explore page and asset still own by seller.

[sync-by-unito]

➤ Tammy Yang commented:

Please wait 10min and check again (it takes some time). Also, please check the Buyer account, I am pretty sure it can succeed.

[sync-by-unito]

➤ Kenny Hung commented:

detail information
asset: bafybeid2bssdstrbjc3wzktrkxfwd7budmnwg6i5h6hbuuisjik7vlkcva
seller: [email protected] ( mailto:[email protected] )
buyer: [email protected]

[sync-by-unito]

➤ Ethan Wu commented:

i checked the logs there was an error in the transfer step:

Workflow error - Plugin action transfer error: Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ( https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ) ] (error={"reason":"execution reverted: ERC20: transfer amount exceeds balance","code":"UNPREDICTABLE_GAS_LIMIT","method":"estimateGas","transaction":{"from":"0x7dFCedd2a008d3c0cb09887D5f03e4f01B8538e6","gasPrice":{"type":"BigNumber","hex":"0x012a05f200"},"to":"0xeCEB87cF00DCBf2D4E2880223743Ff087a995aD9","data":"0xa9059cbb00000000000000000000000052feadb805857046ff8bc227c10eea2cf31750200000000000000000000000000000000000000000000000519c54d087ab770380","accessList":null},"error":{"reason":"processing response error","code":"SERVER_ERROR","body":"{"jsonrpc":"2.0","id":51,"error":{"code":3,"message":"execution reverted: ERC20: transfer amount exceeds balance","data":"0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000002645524332303a207472616e7366657220616d6f756e7420657863656564732062616c616e63650000000000000000000000000000000000000000000000000000"}}","error":{"code":3,"data":"0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000002645524332303a207472616e7366657220616d6f756e7420657863656564732062616c616e63650000000000000000000000000000000000000000000000000000"},"requestBody":"{"method":"eth_estimateGas","params":[{"gasPrice":"0x12a05f200","from":"0x7dfcedd2a008d3c0cb09887d5f03e4f01b8538e6","to":"0xeceb87cf00dcbf2d4e2880223743ff087a995ad9","data":"0xa9059cbb00000000000000000000000052feadb805857046ff8bc227c10eea2cf31750200000000000000000000000000000000000000000000000519c54d087ab770380"}],"id":51,"jsonrpc":"2.0"}","requestMethod":"POST","url":"https://bsc-dataseed.binance.org/"}} ( https://bsc-dataseed.binance.org/"}} ), tx={"data":"0xa9059cbb00000000000000000000000052feadb805857046ff8bc227c10eea2cf31750200000000000000000000000000000000000000000000000519c54d087ab770380","to":{},"from":"0x7dFCedd2a008d3c0cb09887D5f03e4f01B8538e6","gasPrice":{"type":"BigNumber","hex":"0x012a05f200"},"type":0,"nonce":{},"gasLimit":{},"chainId":{}}, code=UNPREDICTABLE_GAS_LIMIT, version=abstract-signer/5.7.0) at Logger.makeError (/var/task/node_modules/@ethersproject/logger/lib/index.js:238:21) at Logger.throwError (/var/task/node_modules/@ethersproject/logger/lib/index.js:247:20) at /var/task/node_modules/@ethersproject/abstract-signer/lib/index.js:365:47 at processTicksAndRejections (internal/process/task_queues.js:97:5) at async Promise.all (index 6)

[sync-by-unito]

➤ Tammy Yang commented:

Kenny Hunghttps://bscscan.com/address/0x7dFCedd2a008d3c0cb09887D5f03e4f01B8538e6 ( https://bscscan.com/address/0x7dFCedd2a008d3c0cb09887D5f03e4f01B8538e6 )

Please ask Joanne Yang to send 50K NUM to the wallet (budget: product dev)

[sync-by-unito]

➤ Joanne Yang commented:

已轉 38K NUM
https://bscscan.com/tx/0xcc9491f1a8dc32db6d28d7aea1c8d00acb58081f7758561064410fe766d3ad6b ( https://bscscan.com/tx/0xcc9491f1a8dc32db6d28d7aea1c8d00acb58081f7758561064410fe766d3ad6b )

[sync-by-unito]

➤ Kenny Hung commented:

Tammy YangEthan Wu (cc Scott YanSherry Chung)
I have tried buying through moonpay again, it could work. But I found other 2 issues about it.

1. [issue] the asset should disappear on original owner, when it is sold. ( https://app.asana.com/0/1201016280880500/1203139504705448/f )
2. [issue] after the prod has been sold, it should disappear immediately on explore tab ( https://app.asana.com/0/1201016280880500/1203139504705444/f )

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung I have responded.

1. I think when the order goes through, maybe you need to refresh the profile tab to see the change.
2. it doesn't disappear immediately because the deal is happening in the background. when the order confirms it will disappear.

[sync-by-unito]

➤ Tammy Yang commented:

Kenny Hung do we have the video recording to show the checkout status? Please provide it to Vera Wu so that she can help communicate with Moonpay and get our API key published.

[sync-by-unito]

➤ Kenny Hung commented:

Vera WuSofia Yan There is the moonpay process record.

[sync-by-unito]

➤ Tammy Yang commented:

Some discussions related to the issues only found after API key goes Live can be found in this task Re-test after Moonpay widget is deployed to production ( https://app.asana.com/0/0/1203042208408125/f )

[sync-by-unito]

➤ Tammy Yang commented:

Suggestion from code review:

It is important that we have the reference for QA for exception cases like this miro frame ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764538469411040&cot=14 ) (or see attached email). Pass code review for UI update, but should add the reference in the future.