Generate tmp_token for reviewing private profile instead of sending JWT token

[sync-by-unito]

Related task:

• ✓ [issue] press cid on detail-page on asset tab, the asset profile url doesn’t have tmp_token parameter.
• ✓ support tmp_token to access asset profiles (v-220829-nse-bubble-patch release note)

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

[sync-by-unito]

➤ Ethan Wu commented:

this is complete:

[sync-by-unito]

➤ Ethan Wu commented:

miro: https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534137249889&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534137249889&cot=14 )

[sync-by-unito]

➤ Kenny Hung commented:

Ethan Wu(cc Tammy Yang)
iOS can't open the nse asset profile
reproduce steps

1. open app & go to profile page
2. press a private asset & press id number
3. it will display the blue progress on the top then nothing happened.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung let me investigate. Does it happen in Android?

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung can't reproduce on my own iOS device. see attachment

[sync-by-unito]

➤ Ethan Wu commented:

wait how are you testing this on iOS? 0.66.2 is using LIVE branch

[sync-by-unito]

➤ Kenny Hung commented:

I use the 0.66.0 it’s using qa branch

[sync-by-unito]

➤ Ethan Wu commented:

ok so i am able to reproduce this issue.

I tried it out on the browser and it works. does this issue exist on android?

it seems like the the run javascript is not running on iOS for some reason.

[sync-by-unito]

➤ Kenny Hung commented:

android is pass, can work.
But it seems open the link slower than before.

[sync-by-unito]

➤ Ethan Wu commented:

yes that is because it needs to check the jwt token and generate a one-time token instead of directly opening the link.

[sync-by-unito]

➤ Ethan Wu commented:

ok i've come up with a solution that should work for both iOS and Android and should also improve the link performance as well

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung ^^ see messages above

[sync-by-unito]

➤ Kenny Hung commented:

Just confirm it should be passed code review by Tammy Yang ?

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung the process is the following:

qa pass than code review sent

[sync-by-unito]

➤ Kenny Hung commented:

re-test is passed.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan WuKenny Hung (cc Sherry ChungScott Yan )

As this sprint focus is “quality”, any implementation that make the quality lower will not be considered as “passed, and performance is #1 factor we need to consider when talking about quality.

Since the implementation of this feature slow down the performance, please revert it from the current qa-release and submit a retest.

The implementation without loosing performance can be schedule in sprint 22.10.10

[sync-by-unito]

➤ Ethan Wu commented:

The fix of this feature had fixed the performance issues. Maybe Kenny Hung can confirm

[sync-by-unito]

➤ Ethan Wu commented:

I will submit a new flow diagram if Kenny confirms the performance improvement.

[sync-by-unito]

➤ Kenny Hung commented:

Tammy Yang
yes, after Ethan Wu fixed, when user press nid and open the link just like before.

[sync-by-unito]

➤ Ethan Wu commented:

updated date flow: https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534242799868&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764534242799868&cot=14 )