Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v230619-capture-app-ionic-launch (push from 0613) #2773

Closed
sync-by-unito bot opened this issue Apr 28, 2023 · 36 comments
Closed

v230619-capture-app-ionic-launch (push from 0613) #2773

sync-by-unito bot opened this issue Apr 28, 2023 · 36 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 28, 2023

﹍Product code:﹍

﹍Release milestone:﹍

﹍Testing level:﹍

﹍Release note:﹍

﹍Expectation:﹍

﹍Known Issue:﹍

﹍Limitation:﹍

﹍Test Link﹍:

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

  • A. Full test + backward compatibility
  • B. Full test, no backward compatibility
  • C. Feature test
  • D. Issue fix retest
  • E. Growth

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung
@sync-by-unito sync-by-unito bot changed the title Release note template v230516-capture-app-ionic Apr 28, 2023
@sync-by-unito sync-by-unito bot changed the title v230516-capture-app-ionic v230530-capture-app-ionic May 1, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 1, 2023

➤ Tammy Yang commented:

Due to the schedule update, push this to sprint 23.05.22

@sync-by-unito sync-by-unito bot changed the title v230530-capture-app-ionic v230613-capture-app-ionic May 21, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 21, 2023

➤ Tammy Yang commented:

Considering v230516-capture-app-ionic-internal ( https://app.asana.com/0/1201016280880500/1204317408460665/f ) has not yet completed, we will NOT have any Ionic release in this sprint.

@sync-by-unito sync-by-unito bot changed the title v230613-capture-app-ionic v230613-capture-app-ionic-launch Jun 12, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Kenny Hung commented:

Sam Please help to mention which tasks you need to push to next sprint. Thanks.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Sam commented:

Kenny Hung, I would like to push these to next sprint

Yesterday I also worked on this one but couldn't figure out the root cause.

[Issue] Capture app doesn't show the asset which uploads from dashboard ( https://app.asana.com/0/0/1204559093594742 ) I will work on it today 2-3 hours and if I can not fix it probably we might push it to next sprint as well.

Please let me know what you think.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 13, 2023

➤ Kenny Hung commented:

Tammy Yang ^^ This part needs your confirmation.

As my side, I could agree that. Because of main feature of this version is [Sprint 2] Upload video(SHORT) ( https://app.asana.com/0/0/1204202515424193 ). Meanwhile this version will publish with ✓ v230516-capture-app-ionic-internal ( https://app.asana.com/0/0/1204317408460665 ) together.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 16, 2023

➤ Kenny Hung commented:

Sam (cc Scott Yan ) Just confirm, Will you release this version today?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 16, 2023

➤ Sam commented:

Kenny Hung, can we aim for Monday?

I need to clean up v230516, v230613 local code branches.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 16, 2023

➤ Kenny Hung commented:

Tammy YangSam (cc Scott Yan)

Considering Sam need more time to release, I'll push this release to next Monday & add it into patch sprint.

I'll change the date code of this release.

@sync-by-unito sync-by-unito bot changed the title v230613-capture-app-ionic-launch v230619-capture-app-ionic-launch (push from 0613) Jun 16, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 19, 2023

➤ Sam commented:

Release reminder submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1687176145510449 ).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 21, 2023

➤ Kenny Hung commented:

Sam (cc Tammy YangScott YanSherry Chung)

For ionic-v230619,

issue summary, please help to re-release.

  1. For video upload, could you set some limitation for video uploading? I suggest 20mb. (Could refer detail testing data ( https://docs.google.com/spreadsheets/d/1GzCijaVg9E8DVsBZwN_H84ZTS_tXPeUkH_gLpxCEqFg/edit#gid=429794188 ).) -> If user choose more than 20mb video size, it should display error message let user know the uploading limitation.
    1. Android will still crash when upload more than specific size video(every device is different.)
    2. Error message needs to update. It just shows “An error has occurred. Please try again later.” on current version( Sofia Yan please also help to confirm zh-tw text ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 ).)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 21, 2023

➤ Kenny Hung commented:

Sam The new error message is confirmed, please use it. (text ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 ))

Just confirm, will you re-release today?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 21, 2023

➤ Sam commented:

Kenny Hung, Yes i will re-release today. Thank you for text confirmation.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 21, 2023

➤ Sam commented:

Kenny Hung, I'm still working on [issue] 4k videos can not generate thumbnail on some android devices. ( https://app.asana.com/0/0/1204753836143743 ) I got it working ( https://app.claap.io/numbers-protocol/v230627-capture-app-ionic-part-1-c-O35CsUM4Uy-Cj-jUvKgqkqm ) but have some skewed thumbnails while testing so I spent time fixing that.

I will prepare fix re-release v230619 tomorrow.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 21, 2023

➤ Kenny Hung commented:

Sam ( cc Tammy Yang) Please fixed & re-release v230619 first, because this version will public to user.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 21, 2023

➤ Sam commented:

Kenny Hung, yes I will prioritize re-release v230619.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Kenny Hung commented:

Sam Warm remind: QA doesn't received the re-release.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Sam commented:

Kenny Hung release will be submitted today around 5pm

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Sam commented:

Kenny Hung, (cc: Tammy Yang)

[Suggestion summary]

For 1 I suggest 45MB (explained below) as a limit for

  • captured photos/videos
  • picked from gallery photos and videos

For 1a which happens on Android (I can reproduce) I suggest

For 1b which happens on iOS (I can reproduce) I suggest

Kenny Hung, (cc: Tammy Yang) let me know what you think if suggestions are approved I can start deploying firebase release. Currently for show dialog ( https://asana-user-private-us-east-1.s3.us-east-1.amazonaws.com/assets/1200886955782960/1204835672867625/1864071eae1d04a0031b4711d8bc6396?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=ASIAV34L4ZY4JCY6EUOK%2F20230623%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230623T071140Z&X-Amz-Expires=120&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEI7%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCICSYJz5%2BMELE1hBT0vztNnAtdOzaA%2Fvthsi%2FQoqT3nHVAiEAlY%2FzERpM5ohN3Dv1QfVXSDLIGExUhTPbQ8nILmh5DpEquwUI5%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FARAAGgw0MDM0ODM0NDY4NDAiDDyLMydvREVzAE3FZSqPBS6pRRlPfagY%2BTcc7UR6An%2BdysiPHcnsKT7MhEZChFdams2Vx4tjxnswh2U6hc8r7oIo4%2FLlPwAJ1Xah6glkOEgxeGuaHHw2Jbd6Dpebpz%2FfxrRAcrU6wASMQ4ORhYExeuQsu6kUzprvPMjt7zzCBRFKyrpprYDIhaeKDOCnA3vFZOWSb7SxOEo6lLhSGFNHs1zGzVofpniFGPRLFoyD5dVkulmKs85eHRkU7z1vyaXqk8LN4ggqC16eWqLElzcU9TehwFXz7asn%2BlcZr%2BkgN8FDujTE0aVN9a5AGQ3PAxZmQrBBEzLx%2B%2FPbIasJQCtx9rgfAt%2BtuSTq8b6z7aZemz7N7CZpcEohuaGPz%2FwFqjAbe23zxKwmLAeICry0qrmC7RzQ%2FOEohnrD%2FLRFLsIRTPt%2Br4ZoFaKvddZpVPcDSZVb8blwWyTrCATJme62dsl97hsoPMWlFnTFzZ1aWH%2Fl%2BsmIZOUkmPzbRJql9%2FFSPFqoKGnDLoDBL8W5e5%2B7ezblwDFicTb0CTua1hNxgLEFSKvQpegnxlNYfbch8bnCCbcGt28PRlzAay7u9VfKYNHYs%2F5bMzjzUzW5sFJByULS5uaIIFwgJDzl01Z4X%2Brvj36zt%2F0WH9tvjPYUAq1hM%2FnC6Ov8ev1ZG7JvtOrOzifbATy3508hFfBBDaFxbJN6J82%2BF7p3Vi0d%2FgPQ%2Fkas6Gl%2F5DPP7CUR1mWdPs1ZNUI0M%2BJRuLfCJkNzSCEuw5MhvGWALpVyJ9qM%2BNclmw9ZoDW3GBNPOOgAqJge1DiVUX22%2B3OMwzGX9gN4FrUBrJWTBIDS%2BhmEBAFnAkbybw5ScuhtNGrZA19nhREGbpqBS3fYOXY%2BWklpB8nC2aG0GLOEiPIwxdnUpAY6sQGFIOg%2Bh6P6rUV5y2o%2BJkyloCw6J05n6DdKIrrZd5ghk2oo0QmtW2YPvUyLHyAg4any5hKCKeETFp1NCYIseKhqhzW0L%2BzusmRH4BXZdtrPKsyLwu0UWYXqUsFTkYReATIX9F2E8G2R3iR9AWucq9zttWmctDQdAix1ou9ctzvC4xhdA31NWSsC8%2FxkiY61dbsr15PVSpgz36aFhqdgNlTwZre%2B%2FRMcT3CXK7iIkE%2BXw7M%3D&X-Amz-Signature=338c1b25d82f19d698aec898867b07358b924633c055ad8fbe88371db573b06b&X-Amz-SignedHeaders=host&x-id=GetObject#_=_ ) we have this translations ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700&range=C92:D94 ) (Your device does not have sufficient me...)

[Suggestion detailed]

  1. I recorded 15, 30, 45, 50, 55, 60 MB videos
  2. I tried on Galaxy M12, it could upload up 50 MB
  3. I tired on iPhone 6+, it could upload up to 45MB (after 45 MB it shows An error has occurred. Please try again later)

NOTE: it does not matter if the photo/video was captured by camera or picked from gallery or if the video was 4k or not. The only thing matter is file size. Therefore I recorded 15, 30, 45, 50, 55, 60 MB videos.

QA TIP: If QA needs to generate sample videos for testing 15, 30, 45 MB etc.

  1. Record 2-3 videos with native camera
  2. Check video sizes.
  3. And ask GPT how long ( https://chat.openai.com/share/cd25dd60-323c-4c35-8a8f-01447b7ff4e8 )you should record to get 15, 30, 45 MB videos. For example I recorded 4 second video on my Galaxy M12 it took X MB and I recorded 7 second video it took Y MB. After this information GPT can give you how long you should record to get video of specific size)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Kenny Hung commented:

Sam So, you suggest setting 45mb as limitation?

But I tried 38mb on iPhone 8, it shows the error message.

If you suggest more, we can extend to 30mb. In case, some users of lower devices will happen issues.

BTW, I can't see the dialog link, just see the xml.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Sam commented:

Kenny Hung, here is the demo of show dialog.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Sam commented:

Kenny Hung, in iPhone 8 38MB video how long it's duration?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Kenny Hung commented:

Sam 41 seconds → iphone 8 test video.

For dialog of text, it's different with the https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 )

Please refer the text on that sheet.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Sam commented:

Kenny Hung, 41 seconds 👌.

Kenny Hung, which text are you referring can you please share cell link or at least search words. I open the google sheet but it shows 1st row 1st column.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Kenny Hung commented:

Sam

text: https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700 ) (row 102)

You could change the numbers of MB to 30.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Sam commented:

Kenny Hung, okay I got the translations.

Just to confirm

  1. We use 30 MB as max allowed
  2. We use this translation ( https://docs.google.com/spreadsheets/d/1tC9YOFjozxjo77PhstFjyOO0O9wat17UqhaofeT_Poo/edit#gid=654354700&range=D102 ) for dialog shown in insufficient memory demo (1).mp4

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Kenny Hung commented:

yes

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2023

➤ Sam commented:

Kenny Hung, (cc: Tammy Yang)

Release submitted ( https://airtable.com/app4oLOHhBT06Hivf/tblcLcxnayIP3LXji/viwgAesfw3RiWTUv2/rect9OG1AYSUZu0Ua?blocks=hide ).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 24, 2023

➤ Kenny Hung commented:

Sam (cc Tammy Yang) ionic-v230619 re-release fail

issue summary

  1. [issue] On android device, user can't upload image ( https://app.asana.com/0/1201083422707776/1204886973759722/f ) → Need to fix
  2. [issue] On iOS device, when user choose video to upload, needs to wait for 5-10s to enter to preview page. ( https://app.asana.com/0/1201083422707776/1204886973759707/f ) -> Only iOS, QA test 15s video, it needs 3-5s to enter preview page, conditional pass. Suggest next sprint to fix.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 26, 2023

➤ Sam commented:

Kenny Hung firebase release submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1687761976470669 ).

It will contain [issue] On android device, user can't upload image ( https://app.asana.com/0/1201083422707776/1204886973759722 )

@sync-by-unito sync-by-unito bot closed this as completed Jun 27, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 27, 2023

➤ Kenny Hung commented:

Sam (cc Ethan WuTammy YangScott Yan) For ionic-v230619 re-release qa pass.

issue summary

  1. [issue] On iOS device, when user choose video to upload, needs to wait for 5-10s to enter to preview page. ( https://app.asana.com/0/1201016280880500/1204886973759707/f ) -> Conditional pass, Current status is not perfect but it’s acceptable. When user choose 15s or lower video, it needs within 5s. If user choose bigger video, it needs more loading time to enter preview page.
  2. [issue] The flash is not appear in the photo taking by iOS ( https://app.asana.com/0/1201016280880500/1203749475533458/f ) -> Conditional pass, Not 100% happened & it also happened on previous version.
  3. [issue] Only iOS - user can’t save video asset on local device sometimes ( https://app.asana.com/0/1201016280880500/1204693730873346/f ) -> Conditional pass, Not 100% happened & it also happened on previous version.
  4. [FR] Date format should be aligned with asset profile ( https://app.asana.com/0/1201083422707776/1204903049554693/f ) -> It’s iframe side, conditional pass, it could let user see the creation date clear.

Please submit the code review for next step. Thanks.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 3, 2023

➤ Kenny Hung commented:

Sam (cc Scott YanJames ChienTammy Yang) Just want to confirm

Could you update required iOS version of Capture App to iOS 15.7.7 on this release publish?

It's because we found the old device such as iPhone 6s, they need to update iOS 15 then they could open Capture App normally. It's not really urgent, just want to confirm this action effort.

If it will affect the progress of official release, we could do it next launch release.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 5, 2023

➤ Kenny Hung commented:

Sam Warm remind, QA doesn't receive the official release.

Will you release today or need more time?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 6, 2023

➤ Sam commented:

Kenny Hung, release reminder submitted ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1688639620409579 ). For testing please use version 0.81.3 from TestFlight/PlayStore

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Kenny Hung commented:

Sam I need to confirm with you below

  1. Comment by @kenny Hung on v230619-capture-app-ionic-launch (push from 0613) ( https://app.asana.com/0/0/1204495833338689/1204952475988543/f )
  2. (for buuble branch control updated) capture app flavours should be built automatically by CI/CD ( https://app.asana.com/0/1201016280880500/1204576787140259/f )this task is completed?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Sam commented:

Kenny Hung, regarding

  1. yes we can set iOS 15 as minimum requirement I can add it to v230711-capture-app-ionic (postpone from 0627) ( https://app.asana.com/0/1201016280880500/1204833080003292/f ) that I will release tomorrow on firebase.
  2. not yet, need some admin privileges can be James Chien, I added comment Comment by @sam on (for buuble branch control updated) capture app flavours should be built automatically by CI/CD ( https://app.asana.com/0/0/1204576787140259/1204978313978296/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 10, 2023

➤ Kenny Hung commented:

Sam

#1 Okay, Thanks.

#2 Thanks for updating the progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants