Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent for .NET 6.0 #1044

Closed
CharliePoole opened this issue Nov 24, 2021 · 10 comments · Fixed by #1119
Closed

Agent for .NET 6.0 #1044

CharliePoole opened this issue Nov 24, 2021 · 10 comments · Fixed by #1119

Comments

@CharliePoole
Copy link
Collaborator

@nunit/engine-team

It's certain we will want one eventually. Do we want one for the 3.13 release?

I think it's easy to add ... pretty much a copy of the 5.0 launcher code. Drawback is everyone who works on the engine needs to have it.

One way to lessen the developer impact would be to include it conditionally and only define the condition in our CI build.

Thoughts?

@patlgrc
Copy link

patlgrc commented Nov 24, 2021

We use the engine and we are migrating all our tests to .Net 6.
Need that agent.

@mikkelbu
Copy link
Member

I don't mind having a .NET 6.0 agent, and I think we already used this conditional approach when we added .NET 5 - see #835.

@rprouse
Copy link
Member

rprouse commented Nov 24, 2021

Installing .NET 6.0 on developer machines is easy these days so I have no issue with it.

@CharliePoole
Copy link
Collaborator Author

Great. I'll add and test the agent first, then look at the approach used in the PR, which @mikkelbu referenced. I wasn't aware of that behavior because I have all the SDKs we use installed.

@CharliePoole
Copy link
Collaborator Author

Whoops! I misunderstood. PR #835 conditionally runs netcoreapp3.1 tests under .NET 5.0 if it is installed. It doesn't provide a .NET 5.0 agent so it's of no use to someone with .NET 5.0 tests, perhaps because they reference a .NET 5.0 application.

WRT .NET 6.0, we already support it in the sense that you can run .NET Core 3.1 tests under .NET 6.0. But that isn't what was being requested, if I understood correctly.

@mikkelbu
Copy link
Member

Then it was I who misunderstood the change in #835 (so much for working after midnight)

@CharliePoole
Copy link
Collaborator Author

So we don't have a .NET 5.0 agent either. See #858.

I imagine that being able to write and run .NET Core 3.1 tests under 5.0 or 5.6 is sufficient for a majority of users. It may not be a large majority, however. Any thoughts on that @nunit/engine-team ?

Adding a new agent is pretty easy in principle, but it involves a lot of steps. We need to build the agent, test it, package it and test the package. They are all doable steps, however. Unfortunately, I'm currently having a problem building the agent for .NET 6.0, which could just be an issue with my own configuration. Can someone else try that please?

If somebody else runs into the same problem, then I think we might need to leave this out of the release. I don't have any problems adding 5.0, however, so we could do that much. Alternatively, either of them could be postponed to the next release. The cadence of releases is a general issue I want to discuss in the @nunit/engine-team in any case.

@CharliePoole
Copy link
Collaborator Author

I'm taking this out of the 3.13 release. See my comment on #858, which applies here as well.

@CharliePoole CharliePoole removed this from the 3.13 milestone Nov 25, 2021
@mikkelbu
Copy link
Member

I think it is fine to leave the new agents out of the release.

@CharliePoole
Copy link
Collaborator Author

This issue has been resolved in version 3.15.0-beta1

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants