Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of NUnit Net Core Runner executable #1224

Closed
Tracked by #1258
CharliePoole opened this issue Sep 24, 2022 · 5 comments
Closed
Tracked by #1258

Change name of NUnit Net Core Runner executable #1224

CharliePoole opened this issue Sep 24, 2022 · 5 comments
Assignees
Milestone

Comments

@CharliePoole
Copy link
Collaborator

@rprouse @mikkelbu @jnm2 @nunit/engine-team @nunit/framework-team

Strictly speaking, this would be a breaking change and should not be done in 3.16.

However, I have had so much confusion in issues between people using the two different runners, with entirely different feature sets, both called nunit3-console.exe. That it's tempting to do it without waiting for 4.0. I'm thinking of calling it nunit-netcore-console.exe.

This would break interactive usage as well as use of the runner in scripts... i.e. .\net6.0\nunit3-console.exe would need changing.

Since I'm proposing this primarily for my own convenience in handling bug reports, I'll accept the result of a vote. :-)

@CharliePoole CharliePoole added this to the 3.16 milestone Sep 24, 2022
@rprouse
Copy link
Member

rprouse commented Sep 26, 2022

I don't have a strong opinion on this. Do you know of any tools like Cake that would need to be updated to work with the new name?

@CharliePoole
Copy link
Collaborator Author

@rprouse Only that the scripts will need to be updated. I think most links get forwarded but I'll do more research.

@mikkelbu
Copy link
Member

@CharliePoole I think the name is fine, and I think it makes sense to change the name even if it is a breaking change. If it is mentioned explicitly in the release notes, then I think people can adapt to it.

@CharliePoole
Copy link
Collaborator Author

@mikkelbu @rprouse In that case, I think I'll go ahead and do it.

@rprouse Thinking more about your question, I realized that the cake extensions similar to the one you maintain would need to be updated, but only if they use the .NET Core runner. I don't know of any that do that. Also, we can keep the dotnet CLI command the same.

@CharliePoole CharliePoole self-assigned this Oct 4, 2022
@CharliePoole CharliePoole added the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Oct 31, 2022
@CharliePoole
Copy link
Collaborator Author

This issue has been resolved in version 3.16.0

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

@CharliePoole CharliePoole removed the PortToVersion4 Version 3 change needs to be ported to the version 4 code in main label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants