Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1182 missing in 3.17 (Don't throw exception when VS Solution contains a .NET Standard assembly) #1398

Closed
LinusNilssonTwoday opened this issue Apr 23, 2024 · 3 comments · Fixed by #1423
Assignees
Labels
Bug Porting Porting a fix to another version branch
Milestone

Comments

@LinusNilssonTwoday
Copy link

Issue #1182 was fixed in 3.16. The fix was was ported to main (to become 4.0), but is missing in 3.17. I read somewhere that 3.17 was branched from 3.15, which might explain it. I don't know whether there are more fixes from 3.16 that are missing in 3.17, but #1182 is affecting us at the moment.

Fix in version3: #1268
Port to main: #1299

@OsirisTerje
Copy link
Member

OsirisTerje commented Apr 23, 2024

@LinusNilssonTwoday Thanks for pointing it out. This seems like an easy one to port over.

And yes, you're right about the versions.

@OsirisTerje OsirisTerje added this to the 3.18 milestone Apr 23, 2024
@OsirisTerje OsirisTerje added Bug Porting Porting a fix to another version branch labels Apr 23, 2024
@CharliePoole CharliePoole self-assigned this Jun 10, 2024
@CharliePoole
Copy link
Collaborator

Strange, I see I merged the change in PR #1282 but it's not there any longer and there is no history of that commit. Well, here goes again.

@LinusNilssonTwoday
Copy link
Author

Thanks for fixing it (again). :) Will wait for the 3.18 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Porting Porting a fix to another version branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants