Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fullscreen toggle on double click does not work #79

Open
1 task done
xiaojiuwo1993 opened this issue Jan 9, 2021 · 5 comments
Open
1 task done

Disable fullscreen toggle on double click does not work #79

xiaojiuwo1993 opened this issue Jan 9, 2021 · 5 comments
Labels
C-bug Category: bug E-OS-macos Environment: OS: macos E-VLC-B-64 Environment: VLC bitness: 64 bit E-VLC-V-3.0 Environment: VLC version: 3.0 S-info-needed Status: info needed

Comments

@xiaojiuwo1993
Copy link

xiaojiuwo1993 commented Jan 9, 2021

Checklist

Environment

  • OS: macOS 10.15.7
  • VLC version: 3.0.11.1
  • VLC bitness: intel64
  • Plugin version: 3.0
  • Plugin bitness: N/A

Describe the bug

When i followed the tutorial of mac os vlc, then I selected disable fullscreen toggle on double click and restart, the double click still activate full screen and single click do pause!

Steps to reproduce

follow the mac os tutorial then select disable fullscreen toggle on double click

Observed behavior

double click full screen still work

Expected behavior

double click enables pause/play function rather than full screen

Additional info

@xiaojiuwo1993 xiaojiuwo1993 added the C-bug Category: bug label Jan 9, 2021
@nurupo
Copy link
Owner

nurupo commented Jan 9, 2021

Can you screenshot the settings you have set in Video -> Filters -> Pause click?

@nurupo nurupo added E-OS-macos Environment: OS: macos E-VLC-B-64 Environment: VLC bitness: 64 bit E-VLC-V-3.0 Environment: VLC version: 3.0 S-info-needed Status: info needed labels Jan 10, 2021
@xiaojiuwo1993
Copy link
Author

截屏2021-01-11 下午8 01 32

@nurupo
Copy link
Owner

nurupo commented Jan 13, 2021

Hm, can't reproduce this on Linux. I don't own a macOS machine so I rely on VLC behaving the same across OSes.

I have added some debug printing in the debug branch. Could you use that version of the plugin, run VLC as:

vlc --verbose 2 /path/to/a/video/file 2>&1 | grep ' pause_click '

then double click on the video just once, causing the window to full screen, then close VLC and copy the log you got in the console?

Here is a binary in case you don't want to built it from source: vlc-3.0-macosx.zip

@nurupo
Copy link
Owner

nurupo commented Jan 13, 2021

In your screenshot you have assigned full screen toggle to the middle button. Does VLC full screen when you click on the middle mouse button?

@xiaojiuwo1993
Copy link
Author

In your screenshot you have assigned full screen toggle to the middle button. Does VLC full screen when you click on the middle mouse button?

middle button do not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug E-OS-macos Environment: OS: macos E-VLC-B-64 Environment: VLC bitness: 64 bit E-VLC-V-3.0 Environment: VLC version: 3.0 S-info-needed Status: info needed
Projects
None yet
Development

No branches or pull requests

2 participants