Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list menu marker changing color #727

Closed
maxomatic458 opened this issue Jan 27, 2024 · 5 comments · Fixed by #728
Closed

list menu marker changing color #727

maxomatic458 opened this issue Jan 27, 2024 · 5 comments · Fixed by #728
Labels
bug Something isn't working

Comments

@maxomatic458
Copy link
Contributor

windows 10; windows terminal.

2024-01-27.21-22-59.mp4
@maxomatic458 maxomatic458 added the bug Something isn't working label Jan 27, 2024
@fdncred
Copy link
Collaborator

fdncred commented Jan 27, 2024

I'm missing the point here. what is changing colors?

@maxomatic458
Copy link
Contributor Author

maxomatic458 commented Jan 27, 2024

@fdncred the marker ("?") changes color to white, when the selection is at the bottom of the terminal

is that intended?

@fdncred
Copy link
Collaborator

fdncred commented Jan 27, 2024

oh, i see it now. nope, that's not intended. not sure why it's doing that. good eye!

@ysthakur
Copy link
Member

ysthakur commented Jan 27, 2024

Looks like print_small_buffer has this bit of code before printing the prompt indicator, but not print_large_buffer (which is why it only happens when you have a bunch of results):

if use_ansi_coloring {
  self.stdout.queue(SetForegroundColor(prompt.get_indicator_color()))?;
}

@fdncred
Copy link
Collaborator

fdncred commented Jan 28, 2024

thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants