Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nushell / VSCode IDE Integration LSP Bughunt & Features #91

Open
27 of 39 tasks
fdncred opened this issue Apr 7, 2023 · 1 comment
Open
27 of 39 tasks

Nushell / VSCode IDE Integration LSP Bughunt & Features #91

fdncred opened this issue Apr 7, 2023 · 1 comment

Comments

@fdncred
Copy link
Collaborator

fdncred commented Apr 7, 2023

This is a list to document bugs found in the LSP or IDE functionality from nushell. Also to list existing functionality and missing features we want to add.

Bugs?

Inlays

  • No inlays in env.nu (let-env's are not variables and therefore do not have inlays. i mistakenly thought they should)
  • No inlays in (Darren's) config.nu (it's a bit flaky. Sometimes works. Sometimes doesn't work. Doesn't work at all for let-env config =)
  • Inlays are using shape? instead of type (they're capitalized). Fixed in make inlays show type instead of shape nushell#8801

Hover

  • No hovers in (Darren's) config.nu (caused complex by big script?)
  • Too many hover messages (Go to a script that is working, hover by moving mouse horizontally along and watch the debug. there are lots of messages with the same info. could be just duplicate logging without uniq names, or could be some type of bug where we're calling nushell too many times. could be what throttling is about? 💡 maybe store current cursor position and not update if it's in a certain range. very minute changes in cursor position currently run the nushell code again.) Marked as done because we have to pass the cursor position
  • Hover over command with a sub-command, the command has a popup, the sub-command says "string" in the popup. Would be nice to treat this as one command.
  • Hover over the custom command name in the declaration of the def should show the help text
  • Hover improve built-ins Improve hovers, including for custom commands nushell#8881
  • Hover scrollbar sometimes is at the bottom instead of top
  • Hover messes up tables like in the ansi command
  • Hover doesn't work at end of file Limit buffer calculation to buffer size not text size #99

Goto Definition

  • Goto Definition goes to the start of the block versus the start of the custom command

Completions

  • Fix variable completions when inside of a block that introduces a new variable

Errors & Warnings

Validation / Check

Configuration

Potential Features to Add

Existing Functionality

  • Goto Definition
  • Hover over variables and get type
  • Hover over custom command and show help popup
  • Hover over built-in command and show help popup
  • Show errors with a red squiggly line
  • Auto complete built-in commands

Cleanup

Pre-Publish

  • Update readme with more screenshots or gifs showing new features
  • Update repo description
  • Update changelog
  • Update version
  • Update regexes
@fdncred fdncred changed the title Nushell / VSCode IDE Integration LSP Bughunt Nushell / VSCode IDE Integration LSP Bughunt & Features Apr 7, 2023
@fdncred fdncred pinned this issue Apr 7, 2023
@sophiajt
Copy link
Contributor

I'd also like to fix variable completions when inside of a block that introduces a new variable. Currently I think we only see top-level variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants