Data Source for categories #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
thetonymaster
approved these changes
Apr 19, 2019
|
|
||
| d.SetId(utils.StringValue(resp.Name)) | ||
|
|
||
| list, err := conn.V3.ListCategoryValues(d.Get("name").(string), &v3.CategoryListMetadata{ |
There was a problem hiding this comment.
My only concern here is pagination, not really an issue here, but I think there is a limit on how much categories can be created, isn't it?
There was a problem hiding this comment.
Yes, I was thinking about it as well, I already have a workaround on this but I think I'll put it in a next enhancement phase.
| list, err := conn.V3.ListCategoryValues(d.Get("name").(string), &v3.CategoryListMetadata{ | ||
| Kind: utils.StringPtr("category"), | ||
| Length: utils.Int64Ptr(500), | ||
| }) |
There was a problem hiding this comment.
Also, this is kinda hard to read, I know it seems easier to send the struct as an argument instead of creating a variable, but it gives unnecessary length to the call
| Length: utils.Int64Ptr(500), | ||
| }) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
related to the comments above, we can move this if to the call above, instead of leaving it here alone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8
We added category_key data source where you can find the values of the category if it has al least one.