Add support for mapstructure decode tag for reusability #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@JRemitz could you update with the latest code from master? |
|
I can and will take a look at this in a bit. |
added 2 commits
May 15, 2020 12:40
|
@marinsalinas - I've updated however I see that the linter is failing on some of the long lines due to the extended tags. What's the best way to break those down? |
|
@marinsalinas - apologies for the delay but finally got around to "fixing" this. Please take a look and let me know what you think. Thanks! |
marinsalinas
suggested changes
May 28, 2020
|
Merged - how about now, @marinsalinas ? |
marinsalinas
approved these changes
May 28, 2020
yannickstruyf3
pushed a commit
to yannickstruyf3/terraform-provider-nutanix
that referenced
this pull request
Nov 9, 2021
Add support for mapstructure decode tag for reusability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to leverage the client v3 API structs for Packer objects to the Nutanix API server. This would require adding support for mapstructure based on Packer's documentation to simplify the process of parsing the Packer config.
I currently have Packer PR 8175 open to add support for Nutanix - any help/insight to align projects would be greatly appreciated!
This includes changes from #80 along with corresponding
mapstructuretags.