From f2883c6574a4cfb0c522481293ca518de20f18f1 Mon Sep 17 00:00:00 2001 From: Tony BRIET Date: Thu, 29 Mar 2018 22:59:21 +0200 Subject: [PATCH] fix(auth): return promise reject on request error --- examples/demo/store/index.js | 0 lib/auth/auth.js | 25 +++++++++++++++---------- 2 files changed, 15 insertions(+), 10 deletions(-) create mode 100644 examples/demo/store/index.js diff --git a/examples/demo/store/index.js b/examples/demo/store/index.js new file mode 100644 index 000000000..e69de29bb diff --git a/lib/auth/auth.js b/lib/auth/auth.js index 4208da4a0..fcd5b74cf 100644 --- a/lib/auth/auth.js +++ b/lib/auth/auth.js @@ -89,9 +89,10 @@ export default class Auth { return this.fetchUserOnce() } - return Promise.resolve(this.strategy.mounted(...arguments)).catch(error => + return Promise.resolve(this.strategy.mounted(...arguments)).catch(error => { this.callOnError(error, { method: 'mounted' }) - ) + return Promise.reject(error) + }) } loginWith (name, ...args) { @@ -103,9 +104,10 @@ export default class Auth { return Promise.resolve() } - return this.wrapLogin(this.strategy.login(...arguments)).catch(error => + return this.wrapLogin(this.strategy.login(...arguments)).catch(error => { this.callOnError(error, { method: 'login' }) - ) + return Promise.reject(error) + }) } fetchUser () { @@ -113,9 +115,10 @@ export default class Auth { return Promise.resolve() } - return Promise.resolve(this.strategy.fetchUser(...arguments)).catch(error => + return Promise.resolve(this.strategy.fetchUser(...arguments)).catch(error => { this.callOnError(error, { method: 'fetchUser' }) - ) + return Promise.reject(error) + }) } logout () { @@ -124,9 +127,10 @@ export default class Auth { return Promise.resolve() } - return Promise.resolve(this.strategy.logout(...arguments)).catch(error => + return Promise.resolve(this.strategy.logout(...arguments)).catch(error => { this.callOnError(error, { method: 'logout' }) - ) + return Promise.reject(error) + }) } reset () { @@ -136,9 +140,10 @@ export default class Auth { return Promise.resolve() } - return Promise.resolve(this.strategy.reset(...arguments)).catch(error => + return Promise.resolve(this.strategy.reset(...arguments)).catch(error => { this.callOnError(error, { method: 'reset' }) - ) + return Promise.reject(error) + }) } // ---------------------------------------------------------------