Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oauth2): support server-side callback #381

Merged
merged 13 commits into from
Jun 23, 2019
Merged

feat(oauth2): support server-side callback #381

merged 13 commits into from
Jun 23, 2019

Conversation

atinux
Copy link
Member

@atinux atinux commented Jun 18, 2019 •
edited
Loading

Bonus: I added $auth in context for easier usage in asyncData

This PR is to enhance the DX on the callback redirect page to support SSR redirect.

It also avoid calling the provider (ex: GitHub) if the query params are not on the callback route.

Before:

nuxt-auth-oauth-csr

After:

nuxt-auth-oauth-ssr

@atinux atinux closed this Jun 18, 2019
@atinux atinux deleted the ssr-oauth2 branch June 18, 2019 15:19
@atinux atinux restored the ssr-oauth2 branch June 18, 2019 15:28
@atinux atinux reopened this Jun 18, 2019
@atinux atinux added the WIP label Jun 18, 2019
@atinux atinux changed the title feat(oauth2): Support server-side feat(oauth2): Support server-side for callback page Jun 18, 2019
@atinux atinux changed the title feat(oauth2): Support server-side for callback page feat(oauth2): [DX] Support server-side for callback page Jun 18, 2019
@codecov
Copy link

codecov bot commented Jun 18, 2019 •
edited
Loading

Codecov Report

Merging #381 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #381   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e7318...c9b6cd1. Read the comment docs.

atinux
atinux commented Jun 21, 2019
View reviewed changes
lib/schemes/oauth2.js Outdated Show resolved Hide resolved
@atinux atinux requested a review from pi0 June 21, 2019 13:07
@atinux atinux removed the WIP label Jun 21, 2019
@pi0 pi0 changed the title feat(oauth2): [DX] Support server-side for callback page feat(oauth2): support server-side callback Jun 23, 2019
@pi0 pi0 merged commit af550d4 into dev Jun 23, 2019
@pi0 pi0 deleted the ssr-oauth2 branch June 23, 2019 18:36
@mmachatschek mmachatschek mentioned this pull request Jun 24, 2019
Merged
@jakul jakul mentioned this pull request Sep 11, 2019
Closed
tanutsun pushed a commit to tanutsun/auth-module that referenced this pull request Dec 18, 2019
@atinux @tanutsun
feat(oauth2): support server-side callback (nuxt-community#381)
93a59a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atinux @pi0