-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose localeProperties property #1016
feat: expose localeProperties property #1016
Conversation
|
Hi @rchl, i made all the mentioned points, changes are committed. |
- add TS types - set code property when using the array of codes form - klona the original locale object so that it's not possible to accidentally modify it - rephrase docs a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. I've done some small changes, please have a look and let me know if those look good to you.
looks awesome from my side, well done! |
Hi, as mentioned here #916, @rchl decided to expose the current locale object, here's how i tackled it, i hope i did it in the correct way since this's my first contribution!
i think we can move the codeFromLocale function from seo-head to utils-common to use it here also, instead of duplication, if confirmed i will commit the change