Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open redirect vulnerability #1092

Closed
1 task done
myanotheraccount opened this issue Mar 7, 2021 · 1 comment · Fixed by #1093, WalksCloud/OfficialWebsite#74 or hisan92/hisan.me#119
Closed
1 task done

open redirect vulnerability #1092

myanotheraccount opened this issue Mar 7, 2021 · 1 comment · Fixed by #1093, WalksCloud/OfficialWebsite#74 or hisan92/hisan.me#119
Labels

Comments

@myanotheraccount
Copy link

Version

nuxt-i18n: 6.12.2
nuxt: 2.14.7

Nuxt configuration

mode:

  • universal
  • [] spa

Nuxt-i18n configuration

i18n: {
strategy: 'prefix_except_default',
...
}

Reproduction Link

https://sty4f.sse.codesandbox.io

Steps to reproduce

https://sty4f.sse.codesandbox.io//google.com/

What is Expected?

redirect to error page

What is actually happening?

redirect to google.com

rchl added a commit that referenced this issue Mar 7, 2021
If the resolved path for a given locale is 404 then don't attempt to
change the path to locale specific. Avoids redirecting unnecessarily to
a route that doesn't exist anyway.

That also fixes the security issue with redirecting to a different
domain but just in case added an additional measure against that.

Resolves #1092
@rchl
Copy link
Collaborator

rchl commented Mar 7, 2021

Thanks for reporting. Preparing a fix in #1093.

@rchl rchl closed this as completed in #1093 Mar 7, 2021
rchl added a commit that referenced this issue Mar 7, 2021
If the resolved path for a given locale is 404 then return
resolved route based on the original path input rather than the
locale-adjusted path. This affects redirects on locale change, page
load, and the behavior of localePath and localeRoute APIs.

Avoids redirecting unnecessarily to a route that doesn't exist anyway.

That also fixes the security issue with redirecting to a different
domain but just in case added an additional measure against that.

Resolves #1092
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment