fix: don't apply any locale-logic to non-existent routes #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the resolved path for a given locale is 404 then don't attempt to change the path to locale specific. Avoids redirecting unnecessarily to a route that doesn't exist anyway. That also fixes the security issue with redirecting to a different domain but just in case added an additional measure against that. Resolves #1092
rchl
changed the title
This was referenced Mar 9, 2021
Closed
Closed
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the resolved path for a given locale is 404 then don't attempt to
redirect to that path. This affects redirects on locale change, page
load, and just the behavior of "localePath" API. Avoids redirecting
unnecessarily to a route that doesn't exist anyway.
That also fixes the security issue with redirecting to a different
domain but just in case added an additional measure against that.
Resolves #1092