Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling route sorting #1241

Merged
merged 3 commits into from
Jul 22, 2021

Conversation

divine
Copy link

@divine divine commented Jul 22, 2021

not sure if this should go to the next version or be in master.

Let me know @rchl what do you think.

Closes #1001

Thanks!

@divine divine changed the title feature: make sortRoutes optional feat: make sortRoutes optional Jul 22, 2021
@rchl rchl changed the base branch from next to master July 22, 2021 12:27
@rchl rchl changed the base branch from master to next July 22, 2021 12:28
@rchl
Copy link
Collaborator

rchl commented Jul 22, 2021

It makes sense to make this against master.

@divine
Copy link
Author

divine commented Jul 22, 2021

It makes sense to make this against master.

Master or next?

rchl changed the base branch from next to master 15 minutes ago
rchl changed the base branch from master to next 15 minutes ago

Thanks!

@rchl
Copy link
Collaborator

rchl commented Jul 22, 2021

Master or next?

master. I've tried to change that but then it includes all changes from next so this has to be done manually.

@divine divine changed the base branch from next to master July 22, 2021 12:56
@rchl rchl changed the title feat: make sortRoutes optional feat: allow disabling route sorting Jul 22, 2021
@rchl rchl merged commit 8a6a056 into nuxt-modules:master Jul 22, 2021
@rchl
Copy link
Collaborator

rchl commented Jul 22, 2021

Thanks!

@divine divine deleted the optional-sortRoutes branch July 26, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid sorting routes by default
2 participants