Fixes #191: Add encodeURI option to allow skipping encodeURI for custom paths #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URI for custom paths.
|
Awesome! Thanks a lot @michaelize ! |
|
Renaming the option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom path has regular expression inside, encodeURI will escape special characters.
/foo/:slug-:id(\\d+)will becomes/foo/:slug-:id(%5Cd+).This PR adds
encodeURIoption per the suggestion in #191. If it's set to false, then custom paths will not be encoded throughencodeURImethod. Since no encoding will happen, the user will need to ensure the correctly encoded paths are specified.