fix: locale not updated on navigation (no fallbackLocale) #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When: - `detectBrowserLanguage` was enabled - `detectBrowserLanguage.fallbackLocale` was not specified - preferred browser language was set to one that nuxt-i18n configuration didn't support then navigating to another locale in SPA mode has updated the URL but failed to change locale. Fix by correcting the logic of browser language detection which was supposed to return false when it didn't manage to detect language but didn't always do that. Resolves #643
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 3 3
Lines 122 122
Branches 32 32
=======================================
Hits 121 121
Misses 1 1 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When:
detectBrowserLanguagewas enableddetectBrowserLanguage.fallbackLocalewas not specifieddidn't support
then navigating to another locale in SPA mode has updated the URL but
failed to change locale.
Fix by correcting the logic of browser language detection which was
supposed to return false when it didn't manage to detect language but
didn't always do that.
Resolves #643