Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't do browser language detection during Nuxt generate #718

Merged
merged 1 commit into from
May 19, 2020

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented May 19, 2020

No description provided.

During generate there is no point in guessing the browser language
as it's not the target's user language anyway.
@rchl rchl force-pushed the fix/ignore-browser-detection-by-generate branch from 26beb9b to 1b1c6fd Compare May 19, 2020 18:47
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #718 into master will decrease coverage by 83.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #718       +/-   ##
===========================================
- Coverage   99.16%   15.83%   -83.34%     
===========================================
  Files           3        3               
  Lines         120      120               
  Branches       33       33               
===========================================
- Hits          119       19      -100     
- Misses          1       71       +70     
- Partials        0       30       +30     
Impacted Files Coverage Δ
src/helpers/routes.js 0.00% <0.00%> (-100.00%) ⬇️
src/index.js 0.00% <0.00%> (-97.68%) ⬇️
src/helpers/components.js 95.00% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f4bff...1b1c6fd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants