Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass to-be-loaded locale when lazy-loading from exported function #752

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented Jun 2, 2020

When using the function export for lazy-loaded locales, the function
will now also receive locale code, apart from context.

Resolves #742

When using the function export for lazy-loaded locales, the function
will now also receive locale code, apart from context.

Resolves #742
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files           3        3           
  Lines         129      129           
  Branches       35       35           
=======================================
  Hits          127      127           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53888db...8f89121. Read the comment docs.

@rchl rchl merged commit 145f3b2 into master Jun 2, 2020
@rchl rchl deleted the feat/lazy-load-pass-locale branch June 2, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add locale variable to loadLanguageAsync promise
1 participant