Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not able to resolve un-hoisted client-side dependencies #486

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Jan 6, 2023

Fixes #485

@rchl rchl force-pushed the fix/unhoisted-client-deps branch from 795fea5 to 7248591 Compare January 6, 2023 22:20
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #486 (2d4cc11) into main (c9894da) will increase coverage by 2.19%.
The diff coverage is 100.00%.

❗ Current head 2d4cc11 differs from pull request most recent head 7248591. Consider uploading reports for the commit 7248591 to get more accurate results

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   69.23%   71.42%   +2.19%     
==========================================
  Files           1        1              
  Lines          52       56       +4     
  Branches       21       23       +2     
==========================================
+ Hits           36       40       +4     
  Misses         13       13              
  Partials        3        3              
Impacted Files Coverage Δ
lib/module.js 71.42% <100.00%> (+2.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rchl rchl merged commit 82071ce into main Jan 9, 2023
@rchl rchl deleted the fix/unhoisted-client-deps branch January 9, 2023 10:32
rchl added a commit to rtibaldo/sentry-module that referenced this pull request Jan 19, 2023
…module-builder-original

* rtibaldo-rewrite-module-builder: (39 commits)
  migrate to module-builder
  chore: release 7.0.2
  fix(deps): update sentry dependencies to ^7.29.0 (nuxt-community#482)
  chore(deps): update all non-major dependencies
  fix: not able to resolve un-hoisted client-side dependencies (nuxt-community#486)
  chore: release 7.0.1
  fix: more accurate type for `serverConfig` option (nuxt-community#484)
  chore: remove dead badge from the readme
  chore(docs): build documentation on every change
  chore: release 7.0.0
  feat: enable tree shaking of Sentry SDK debug code (nuxt-community#481)
  chore(lint): enable linting for more files within the repo
  chore(deps): update lock file
  fix(deps): update sentry dependencies to ^7.28.0 (nuxt-community#478)
  docs: minor updates about dependencies and lazy+tracing
  feat: support plugin path for clientConfig and serverConfig (nuxt-community#477)
  feat(tracing): enable Vue Router instrumentation by default (nuxt-community#476)
  Revert "feat(tracing): enable Vue Router instrumentation by default"
  feat(tracing): enable Vue Router instrumentation by default
  chore(lint): tweak eslint ignore directives for generated plugin files
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sentry/vue dependency not found
1 participant