Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply runtime config last, after merging tracing options #499

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Feb 17, 2023

Fixes #498

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #499 (82369fb) into main (9614795) will not change coverage.
The diff coverage is n/a.

❗ Current head 82369fb differs from pull request most recent head d1337a1. Consider uploading reports for the commit d1337a1 to get more accurate results

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files           1        1           
  Lines          56       56           
  Branches       23       23           
=======================================
  Hits           40       40           
  Misses         13       13           
  Partials        3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rchl rchl merged commit f434ec4 into main Feb 17, 2023
@rchl rchl deleted the fix/runtime-config-tracing branch February 17, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set tracesSampleRate in runtime
1 participant