Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support external configuration in form of *.ts #639

Merged
merged 7 commits into from
Nov 13, 2023
Merged

fix: support external configuration in form of *.ts #639

merged 7 commits into from
Nov 13, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Nov 12, 2023

The serverConfig and customServerIntegrations options did not work with typescript files when trying to use those options with a path variant.

Use jiti to import those files rather than relying on whatever happens by default (relying on native Node ESM support).

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2023 •
edited
Loading

size-limit report 📦

Path Size
fixture: base 381.53 KB (0%)
fixture: lazy 386.28 KB (0%)
fixture: tracing 401.72 KB (0%)
fixture: lazy+tracing 406.43 KB (0%)
fixture: replay 538.58 KB (+100% 🔺)
fixture: typescript 381.66 KB (+100% 🔺)

@rchl rchl changed the title fix: support external configuration in *.ts files fix: support external configuration in form of *.ts Nov 13, 2023
@rchl rchl merged commit e481548 into main Nov 13, 2023
6 checks passed
@rchl rchl deleted the fix/import-ts branch November 13, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rchl