fix: set root
for RewriteFrames integration
#650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After manually inspecting some crashes I've realized that the
RewriteFrames
integration that the module enables by default does more harm than good.In case there are source maps it doesn't really make any difference since stack frame paths are resolved from source maps then.
In case there are no source maps (for example when crash is within the server code and not inside the webpack context) then what
RewriteFrames
does is it strips the whole path leaving just the file name. That can result in justindex.js
being shown, for example, which makes it unclear which file is being referred to.To fix that, set
root
option on the server so that the paths are resolved relative to Nuxt'srootDir
.Also don't enable
RewriteFrames
integration on the client since it doesn't seem to be useful there. It only does something when the stack frame path is a local file path and on the client-side I don't see this being the case.