Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customPath set to false and link alternate #1177

Closed
1 of 2 tasks
existe-deja opened this issue May 21, 2021 · 4 comments
Closed
1 of 2 tasks

customPath set to false and link alternate #1177

existe-deja opened this issue May 21, 2021 · 4 comments

Comments

@existe-deja
Copy link

Version

nuxt-i18n:
nuxt:

Nuxt configuration

mode:

  • universal
  • spa

Nuxt-i18n configuration

i18n: {
    langDir: "lang/lazy/",
    lazy: true,
    defaultLocale: "en",
    locales: [
      {
        code: "en",
        iso: "en-EN",
        file: "en.js",
        domain: "www.something.com"
      },
      {
        code: "en-US",
        iso: "en-US",
        file: "en-US.js",
        domain: "www.en-us.something.com"
      }
    ],
    strategy: "prefix_except_default",
    differentDomains: true,
    parsePages: false,
    pages: {
      about: {
        en: "/about-page",
        "en-US": false
      }
    },
    seo: false,
    vueI18n: {
      fallbackLocale: {
        default: ["en"]
      }
    }
  }

Reproduction Link

https://codesandbox.io/s/nuxt-i18n-template-forked-bk64e?file=/nuxt.config.js

Steps to reproduce

With the en lang (default) set, click on about page link and see the meta link.

What is Expected?

if a page is disabled, it shouldn't be injected in the meta tags.

What is actually happening?

As the doc says https://i18n.nuxtjs.org/seo#automatic-hreflang-generation:

Generates tags for every language configured in nuxt.config.js. The language's ISO codes are used as hreflang values.

So it injects a tag even if the route is disabed.

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@existe-deja
Copy link
Author

that's sad :/

@stale stale bot removed the stale label Jul 21, 2021
@rchl
Copy link
Collaborator

rchl commented Jul 21, 2021

This depends on #984 being solved.

@BobbieGoede
Copy link
Collaborator

Closing this as v7 is not being actively worked on (critical hotfixes only), if this still applies to v8 and later please open a new issue!

@BobbieGoede BobbieGoede closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants