Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edge] navigating from a prefixed route to the home page doesn't work #2247

Closed
saifobeidat opened this issue Jul 19, 2023 · 0 comments · Fixed by #2249
Closed

[edge] navigating from a prefixed route to the home page doesn't work #2247

saifobeidat opened this issue Jul 19, 2023 · 0 comments · Fixed by #2249
Labels
❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf routing v8

Comments

@saifobeidat
Copy link

saifobeidat commented Jul 19, 2023

Environment

OS: Windows 10
Node: 16.16.0
nuxt: "^3.6.2"
"@nuxtjs/i18n": "npm:@nuxtjs/i18n-edge"

Reproduction

my i18n config:

  i18n: {
    baseUrl: 'https://abwaab.com',
    locales: [
      {
        code: 'en',
        country: '',
        iso: 'en',
        lang: 'en',
        file: 'en-en.js',
        dir: 'ltr',
      },
      {
        code: 'ar',
        country: '',
        iso: 'ar',
        lang: 'ar',
        file: 'ar-ar.js',
        dir: 'rtl',
      },
    ],

    strategy: 'prefix_and_default',
    detectBrowserLanguage: false,
    defaultLocale: 'ar',
    lazy: true,
    langDir: 'i18n/',
  }

Reproduction Link:
https://githubd2hhcfsztftm-b3pn--3000--c53ab388.local-credentialless.webcontainer.io/
https://stackblitz.com/edit/github-d2hhcf-sztftm?file=pages%2Fexample.vue,app.vue

Animation

Describe the bug

There was a related issue 2226 and it was fixed in this PR but seems it was fixed partially.

However i tried to test the edge version and there's still a case when you navigate from a prefixed route like /ar/about to the the home page /, it redirects you to the non-prefixed version of that page.. which means to /about

Note: the issue doesn't happen if you navigate from /about to the home /..

Thanks for your efforts, can't wait for the stable release 🔥 🔥

Additional context

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf routing v8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants