'terminate' package uses GPL-2.0 license where 'og-image' uses MIT

[sethidden]

It's used in the package runtime (not as a development tool) here

og-image/src/runtime/nitro/og-image/bindings/chromium/on-demand.ts

Line 30 in 16e1ed6

installChromeProcess.pid && terminate(installChromeProcess.pid)

A change introduced in this commit: e0cdde7

License SPDX in terminate: https://github.com/dwyl/terminate/blob/main/package.json#L32
Also see:

• Possible switch to a permissive license? dwyl/terminate#72
• I think the original author intended terminate to be a development tool, not something you include in runtime, which is why the package itself is GPL - The ps-tree package may be unsafe now. Better find an alternative. dwyl/terminate#35 (comment)

As per GPL-2.0 section 2

2. You may modify your copy or copies of the Program or any portion of it, thus forming a work based on the Program, and copy and distribute such modifications or work under the terms of Section 1 above, provided that you also meet all of these conditions:
   ...
   b) You must cause any work that you distribute or publish, that in whole or in part contains or is derived from the Program or any part thereof, to be licensed as a whole at no charge to all third parties under the terms of this License.

Shouldn't this package be GPL-ed or stop using terminate to keep using MIT?

[manniL]

cc @harlan-zw

[sethidden]

@harlan-zw I read your post in terminate. Could you let me know the particular doubts you're having in regards to the GPL/MIT license?

[harlan-zw]

I was looking for the maintainer to comment ideally.

For context, we need this package as occasionally browser gets stuck open in the CI.

I don't have capacity right now to replace this package with bespoke code or find an alternative fix so changing the license upstream would be ideal. PRs are also welcome of course :)