Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link duplication #333

Closed
dargmuesli opened this issue Aug 7, 2024 · 4 comments
Closed

fix: link duplication #333

dargmuesli opened this issue Aug 7, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@dargmuesli
Copy link

πŸ› The bug

After updating to v6.0.0-beta.1 I have to make the following additions to let my testsuite pass, which look like duplicates of the already existing lines, but with swapped properties:

image

πŸ› οΈ To reproduce

https://github.com/dargmuesli/vio/actions/runs/10290667596/job/28481193061?pr=217

🌈 Expected behavior

There should be no additions for content that already exists, no matter the order of properties.

ℹ️ Additional context

Could be that the issue is not with this module only, but maybe an incompatibility with another seo package. I can try to create a minimal reproduction if the issue's root is not immediately clear to you πŸ’š

@dargmuesli dargmuesli added the bug Something isn't working label Aug 7, 2024
@harlan-zw
Copy link
Collaborator

Hey, thanks for the issue.

I did some digging into your repo but I felt a bit lost on what the issue could be. I have tests specifically for nuxt generate with the i18n module and I don't have these duplicates πŸ€”

If you have any time to make a minimal reproduction it would be super helpful, otherwise will revisit when I get a chance.

@dargmuesli
Copy link
Author

Sure, I was looking through your tests as well for some time and was wondering the same. I just wanted to flag this real quick after updating the SEO tools in case a fix is obvious, but I can also dig deeper and provide a minimal reproduction when time allows.

@dargmuesli
Copy link
Author

Some other update seems to have resolved the issue.

@dargmuesli dargmuesli closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
@harlan-zw
Copy link
Collaborator

FYI I was able to replicate this using Nuxt Content and Nuxt I18n and have pushed up a fix in the latest RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants