fix: properly treat falsy values in context #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atinux
approved these changes
Dec 18, 2020
|
Thank you @AlexanderBelokon |
AlexanderBelokon
force-pushed
the
dev
branch
from
69d8338
to
2ebe282
Compare
|
My pleasure, @atinux !) |
benjamincanac
approved these changes
Jan 7, 2021
This was referenced Jan 18, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly treat falsy values in context
Types of changes
Description
Previously, if a component's attribute referenced a value in context and that value happened to be falsy, it was ignored, which lead to an error. See this sandbox for reproduction.
This PR fixes this problem.
This was discovered while researching #519
Checklist: