fix(content): codeblock parse lang should support other meta #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When codeblock contains other meta, it should not break lang parsing in utils.parseThematicBlock
fuxingloh
added a commit
to fuxingloh/vue-horizontal
that referenced
this pull request
Dec 23, 2020
fuxingloh
added a commit
to fuxingloh/vue-horizontal
that referenced
this pull request
Dec 23, 2020
fuxingloh
added a commit
to fuxingloh/vue-horizontal
that referenced
this pull request
Dec 23, 2020
fuxingloh
added a commit
to fuxingloh/vue-horizontal
that referenced
this pull request
Dec 24, 2020
fuxingloh
added a commit
to fuxingloh/vue-horizontal
that referenced
this pull request
Dec 24, 2020
* Updated README.md * Fixed vue-horizontal.svg text not a path * Updated to use remark-code-import-replace * Removed mock-browser border * Going to hide filename until nuxt/content#691 is fixed * Updated limitations with new scrollbar fix * docs: taxonomy.md * docs: responsive.md
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
I think #621 breaks lang parsing in codeblock when it contains other meta that is not filename. This causes highlightjs not to work as expected. When codeblock contains other meta that is not filename, it should not break lang parsing in utils.parseThematicBlock. Making it difficult to write and use remark plugins that contains meta.
Checklist: