Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-nuxt-content-docs): respect npm client answer #779

Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix(create-nuxt-content-docs): respect npm client answer #779

merged 1 commit into from
Mar 1, 2021

Conversation

nozomuikuta
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #773

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Test notes:

  • Link my local create-nuxt-content-docs package
  • Run npx create-nuxt-content-docs <project_name>
  • Select Npm when asked Package manager

As a result, SAO used npm as client.

pi0
pi0 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix(cli): respect npm client answer fix(create-nuxt-content-docs): respect npm client answer Mar 1, 2021
@pi0 pi0 merged commit 1670c5b into nuxt:dev Mar 1, 2021
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Closed
Merged
@nozomuikuta nozomuikuta deleted the fix/create-nuxt-content-docs branch August 31, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation via npx create-nuxt-content-docs runs with yarn when selecting npm
2 participants
@nozomuikuta @pi0