Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): handle readable ended request #790

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

nozomuikuta
Copy link
Collaborator

@nozomuikuta nozomuikuta commented Feb 22, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #292

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

I added a test to check default options.
If there is a way to check page transition with server middleware, please let me known so that I can add such test.
I removed reqBodyKey according to a review comment that req.body is a standard in Node.js community.

By the way, test was failed due to highlighter snapshot tests.
A color code was not matched in HTML.
I guess CI will fail too.

@atinux
Copy link
Member

atinux commented Feb 22, 2021

Thanks for the fix @nozomuikuta

I think we don't need reqBodyKey since req.body is a standard in Node :)

@pi0
Copy link
Member

pi0 commented Mar 1, 2021

Thanks!

Note for future: We shall use h3.useBody utility later on (and body is express specific)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with express serverMiddleware
3 participants