Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move modern detection from server to utils #5584

Merged
merged 3 commits into from
Apr 23, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Apr 22, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 April 22, 2019 20:27
packages/utils/src/modern.js Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #5584 into dev will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5584      +/-   ##
==========================================
- Coverage   95.67%   95.63%   -0.04%     
==========================================
  Files          81       81              
  Lines        2636     2635       -1     
  Branches      671      671              
==========================================
- Hits         2522     2520       -2     
- Misses         95       96       +1     
  Partials       19       19
Impacted Files Coverage Δ
packages/server/src/server.js 97.7% <ø> (-0.08%) ⬇️
packages/utils/src/modern.js 100% <100%> (ø)
packages/webpack/src/builder.js 93.54% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 93.49% <100%> (-0.77%) ⬇️
packages/vue-renderer/src/renderers/spa.js 87.5% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912ef25...f375c2e. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Apr 23, 2019

Thanks @clarkdo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants