fix(builder): call watch:restart after watch:fileChanged hook

[clarkdo]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

@pi0 Should this be deprecacted ? I don't see any doc is refering it.

If there is anyone using it, this may be a slightly breaking change since there is no builder as param anymore.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[pi0]

@clarkdo Yes. Although almost all hooks should be deprecated in flavor on new namespaces with nuxt 3. This may just be annoying for some module users that are using this hook. Not something emergency.

Still if you feel is good to deprecate sooner feel free to merge. But i vote for deprecating all once with a single PR in flavor of better namespaces.

[clarkdo]

@pi0 Yes, a separated pr make sense.

[clarkdo]

@pi0 I reverted the deprecation change and make hooks run in-order

[manniL]

@clarkdo I tried to fix the PR titled ☺️

[codecov-io]

Codecov Report

Merging #5620 into dev will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##             dev   #5620   +/-   ##
=====================================
  Coverage   95.7%   95.7%           
=====================================
  Files         81      81           
  Lines       2633    2633           
  Branches     670     670           
=====================================
  Hits        2520    2520           
  Misses        95      95           
  Partials      18      18

Impacted Files	Coverage Δ
packages/builder/src/builder.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d5c0c...243968c. Read the comment docs.

[pi0]

If we allow async watch handlers, promise rejection should be somehow handled. Probably via a console.fatal or error.

[clarkdo]

The handler is async now since callHook returns promise, the changing in this pr is just keeping order of the execution.

About the rejection, will restart hook process it by calling console.fatal now ?

[pi0]

@clarkdo Both previously and now errors was unhandled. It was an enhancenment idea to catch and pipe errors to core/nuxt

[clarkdo]

@clarkdo Both previously and now errors was unhandled. It was an enhancenment idea to catch and pipe errors to core/nuxt

Cool, let me add it

@pi0 Can this line cover the case ?

[pi0]

@Clark right. I didn't remembered that.