fix(vue-app): Followup for fix for handle prefetch error (#5687) #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After more investigation I've came to conclusion that keeping previous behavior of marking component as prefetched before we know if it loaded/failed, is the right thing to do. That's because otherwise, when processing many nuxt-links within a page, that code will trigger multiple times, with same component list and trigger loading of them multiple times (which might be optimized by webpack code anyway but still...).
Codecov Report
@@ Coverage Diff @@
## dev #5690 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 81 81
Lines 2645 2645
Branches 673 673
=======================================
Hits 2528 2528
Misses 98 98
Partials 19 19Continue to review full report at Codecov.
|
clarkdo
approved these changes
May 10, 2019
Merged
|
No worries @rchl :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
After more investigation I've came to conclusion that keeping previous
behavior of marking component as prefetched before we know if it
loaded/failed, is the right thing to do. That's because otherwise, when
processing many nuxt-links within a page, that code will trigger multiple
times, with same component list and trigger loading of them multiple
times (which might be optimized by webpack code anyway but still...).
Resolves: #5687
Checklist: