Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts): upgrade ts-loader to v6 #5691

Merged
merged 2 commits into from
May 10, 2019
Merged

feat(ts): upgrade ts-loader to v6 #5691

merged 2 commits into from
May 10, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 10, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

PR for #5667

  • upgrade ts-loader in @nuxt/typescript to v6
  • remove ts-loader in root package.json
  • limitnode >= 8.6 for @nuxt/typescript

@pi0 @kevinmarrec Do we need ts-loader to root package.json ?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from kevinmarrec and pi0 May 10, 2019 10:17
pi0
pi0 previously approved these changes May 10, 2019
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarkdo ts-loader can be safely removed from root package.json

I would suggest to add engines in packages/typescript/package.json as described here : #5667 (comment)

@clarkdo
Copy link
Member Author

clarkdo commented May 10, 2019

@kevinmarrec Sorry I missed adding changed file.

@clarkdo clarkdo requested review from kevinmarrec and pi0 and removed request for kevinmarrec May 10, 2019 10:35
@codecov-io
Copy link

Codecov Report

Merging #5691 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5691   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          81       81           
  Lines        2645     2645           
  Branches      673      673           
=======================================
  Hits         2528     2528           
  Misses         98       98           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8588ca9...1f2ad7e. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #5691 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5691   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          81       81           
  Lines        2645     2645           
  Branches      673      673           
=======================================
  Hits         2528     2528           
  Misses         98       98           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8588ca9...1f2ad7e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants