-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ts): upgrade ts-loader to v6 #5691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clarkdo ts-loader
can be safely removed from root package.json
I would suggest to add engines
in packages/typescript/package.json
as described here : #5667 (comment)
@kevinmarrec Sorry I missed adding changed file. |
Codecov Report
@@ Coverage Diff @@
## dev #5691 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 81 81
Lines 2645 2645
Branches 673 673
=======================================
Hits 2528 2528
Misses 98 98
Partials 19 19 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #5691 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 81 81
Lines 2645 2645
Branches 673 673
=======================================
Hits 2528 2528
Misses 98 98
Partials 19 19 Continue to review full report at Codecov.
|
Types of changes
Description
PR for #5667
ts-loader
in@nuxt/typescript
to v6ts-loader
in root package.jsonnode >= 8.6
for@nuxt/typescript
@pi0 @kevinmarrec Do we need
ts-loader
to root package.json ?Checklist: