Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): don't attach catch handler to already loaded component (fixes #5751) #5752

Merged
merged 1 commit into from
May 16, 2019
Merged

fix(vue-app): don't attach catch handler to already loaded component (fixes #5751) #5752

merged 1 commit into from
May 16, 2019

Conversation

rchl
Copy link

@rchl rchl commented May 16, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Components are not necessarily lazy-loaded. If user overrides webpack
build options with splitChunks:{layouts: false, pages: false}, for
example, pages will be loaded already on loading app.

I was thinking of handling this in the getPrefetchComponents function already, to not return components that are already loaded, but I don't see a way to find that out until we call Component() and that would trigger prefetching in case of lazy-loaded components.

Resolves: #5751

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

…ixes #5751)

Components are not necessairly lazy-loaded. If user overrides webpack
build options with 'splitChunks:{layouts: false, pages: false}', for
example, pages will be loaded already on loading app.
@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #5752 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #5752   +/-   ##
=====================================
  Coverage   95.6%   95.6%           
=====================================
  Files         82      82           
  Lines       2662    2662           
  Branches     683     683           
=====================================
  Hits        2545    2545           
  Misses        98      98           
  Partials      19      19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f391e5d...9c5db94. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt-link prefetch throws an exception when it becomes visible
4 participants