fix(vue-app): don't attach catch handler to already loaded component (fixes #5751) #5752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Components are not necessarily lazy-loaded. If user overrides webpack
build options with
splitChunks:{layouts: false, pages: false}
, forexample, pages will be loaded already on loading app.
I was thinking of handling this in the
getPrefetchComponents
function already, to not return components that are already loaded, but I don't see a way to find that out until we callComponent()
and that would trigger prefetching in case of lazy-loaded components.Resolves: #5751
Checklist: