-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(builder): pass nuxt options to template as nuxtOptions #5792
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5792 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 82 82
Lines 2662 2662
Branches 682 682
=======================================
Hits 2546 2546
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
For docs, I suggest keeping this new (feature) as undocumented. In any stage, we may change the config interface in an incompatible way and this may break users. Maybe we can suggest always cherry-picking needed options into template |
@pi0 Agree |
Types of changes
Description
Fixes: #5783
Related to #5730
Checklist: