Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): Update build indicator style #5834

Merged
merged 2 commits into from
May 30, 2019
Merged

fix(vue-app): Update build indicator style #5834

merged 2 commits into from
May 30, 2019

Conversation

atinux
Copy link
Member

@atinux atinux commented May 30, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Tweak style and fix scopped -> scoped

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@atinux atinux requested a review from pi0 May 30, 2019 11:10
@codecov-io
Copy link

Codecov Report

Merging #5834 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5834      +/-   ##
==========================================
- Coverage   95.68%   95.68%   -0.01%     
==========================================
  Files          82       82              
  Lines        2690     2687       -3     
  Branches      690      689       -1     
==========================================
- Hits         2574     2571       -3     
  Misses         98       98              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.42% <ø> (+0.05%) ⬆️
#unit 92.66% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
packages/cli/src/command.js 98.97% <0%> (-0.02%) ⬇️
packages/config/src/options.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19c6b5...c3480e0. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #5834 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5834      +/-   ##
==========================================
- Coverage   95.68%   95.68%   -0.01%     
==========================================
  Files          82       82              
  Lines        2690     2687       -3     
  Branches      690      689       -1     
==========================================
- Hits         2574     2571       -3     
  Misses         98       98              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.42% <ø> (+0.05%) ⬆️
#unit 92.66% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
packages/cli/src/command.js 98.97% <0%> (-0.02%) ⬇️
packages/config/src/options.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19c6b5...c3480e0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants