-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-renderer): clone spa meta to prevent cache modification #5964
Conversation
This ensures that post-processing of the result object does not cause cache corruption.
8a482d4
to
c306bb0
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5964 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 82 82
Lines 2689 2689
Branches 690 690
=======================================
Hits 2573 2573
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
Is this stuck because the commit starts with |
@ustun no PR is ok and thanks for that ❤️ Sorry for late review. |
This ensures that post-processing of the result object does not cause cache corruption.
When transforming the response in SPA mode via
render:route
hook, settingresult.html
changes the data in cache, which is not ideal.Fixes #5962
Types of changes
Description
Checklist: