Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): correctly load nomodule scripts in safari 10 #6033

Merged
merged 2 commits into from
Jul 6, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jul 5, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix #6032

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from a team July 5, 2019 08:37
@manniL manniL changed the title fix(render): modern mode nomodule scripts are wrongly loaded in safar… fix(renderer): correctly load nomodule scripts in safari 10 Jul 5, 2019
@clarkdo
Copy link
Member Author

clarkdo commented Jul 5, 2019

@manniL In safari 10, nomodule should not be loaded.

@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #6033 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6033      +/-   ##
==========================================
- Coverage   95.69%   95.69%   -0.01%     
==========================================
  Files          82       82              
  Lines        2693     2692       -1     
  Branches      692      692              
==========================================
- Hits         2577     2576       -1     
  Misses         98       98              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.18% <50%> (-0.1%) ⬇️
#unit 92.79% <66.66%> (+0.1%) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/modern.js 98.36% <100%> (+0.05%) ⬆️
packages/webpack/src/plugins/vue/modern.js 86.11% <100%> (-1.39%) ⬇️
packages/utils/src/modern.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9524bca...1f4869b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modern mode doesn’t work on safari 10.1
4 participants