Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-app): use EventSource instead of WebSocket for build indicator #6186

Merged
merged 4 commits into from
Aug 5, 2019

Conversation

atinux
Copy link
Member

@atinux atinux commented Aug 5, 2019

…sockets

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

EventSource are better than Websockets and avoid the limitation of X connected sockets, might also solve Nuxt hanging on reload.

⚠️ This should be merged after nuxt/loading-screen#34 and upgrading the loading-screen dependency.

Checklist:

  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #6186 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6186   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          80       80           
  Lines        2655     2655           
  Branches      683      683           
=======================================
  Hits         2542     2542           
  Misses         97       97           
  Partials       16       16
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.8% <ø> (ø) ⬆️
#unit 92.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599268a...bf7fe62. Read the comment docs.

pi0
pi0 previously approved these changes Aug 5, 2019
@pi0 pi0 changed the title feat(vue-app): move build indicator to use EventSource instead of Web… feat(vue-app): use EventSource instead of WebSocket for build indicator Aug 5, 2019
@pi0 pi0 mentioned this pull request Aug 5, 2019
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSE working fine!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants