fix(vue-app): prevent looping on error during render of error page #6217
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6217 +/- ##
=====================================
Coverage 95.7% 95.7%
=====================================
Files 79 79
Lines 2652 2652
Branches 683 683
=====================================
Hits 2538 2538
Misses 98 98
Partials 16 16
Continue to review full report at Codecov.
|
|
Just to make sure: could someone please confirm it is correct that navigation to |
| test('/info prints empty page', async () => { | ||
| await page.nuxt.navigate('/info') | ||
|
|
||
| expect(await page.$text('#__layout')).toBe('') |
There was a problem hiding this comment.
Is this correct behaviour? In dev mode it returns an error page, with build/start it doesnt
There was a problem hiding this comment.
Well it should displayed 'An error occured` error page I believe 🤔
There was a problem hiding this comment.
I checked with the dev branch and there the page is empty as well.
We could capture this error though as its being passed through errorCaptured. It just seems that by default in production there is no error handler so it just blanks out with an error in the console.
There was a problem hiding this comment.
loading-indicator will go to a bad state in case of fatal errors and SPA mode. Otherwise, that blank screen is somehow unexpected.
pi0
changed the title
Follow up of: #4257
Resolves: #4140
Types of changes
Description
The
$forceUpdatecannot be called async with eg $nextTick as then the NuxtError component would still be rendered and trigger the infinite reloading.Checklist: